[dpdk-dev] [PATCH 0/4] Broadcom 10G NIC Poll Mode Driver

Thanks Stephen for all the info! Do you expect this pmd driver will be in sync with FreeBSD repo in the future, or it's going to be diverged? I am just asking from a maintenance stand point. On Sat, Feb 7, 2015 at 11:15 PM, Stephen Hemminger wrote: > Source was from FreeBSD. > > changes were to

[dpdk-dev] "virtual" C++ keyword used in rte_devargs.h and causes compilation error in C++

"virtual" is a reserved word in c++. When the c++ compiler "g++" use that header in a "extern way (just generate standard typo for function identifiers)", there`s not way that the compiler posible "turn off" the "virtual" reserved word. If, for example, you guys use the "new" word ... its just the

[dpdk-dev] [RFC PATCH] rte_timer: Fix rte_timer_reset return value

Hi Robert, On 02/06/2015 06:26 PM, Robert Sanford wrote: > Hi Olivier, > > Thanks for reviewing this patch. > Please see my responses to your comments, below. > > I also have one request for you. You probably use git almost every day. > For people who only use git maybe once per year, could you

[dpdk-dev] "virtual" C++ keyword used in rte_devargs.h and causes compilation error in C++

On Sun, Feb 08, 2015 at 04:31:39AM -0300, Ariel Rodriguez wrote: > "virtual" is a reserved word in c++. When the c++ compiler "g++" use that > header in a "extern way (just generate standard typo for function > identifiers)", there`s not way that the compiler posible "turn off" the > "virtual" rese

[dpdk-dev] [PATCH v3 0/5] New Reorder Library

On Fri, Feb 06, 2015 at 03:05:59PM +, Sergio Gonzalez Monroy wrote: > This series introduces the new reorder library along with unit tests, > sample app and a new entry in the programmers guide describing the library. > > The library provides reordering of mbufs based on their sequence number.

[dpdk-dev] [PATCH] enic: silence log message

From: Stephen Hemminger Silence is normal. drivers should speak only when spoken to and not be chatty. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_enic/enic_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c ind

[dpdk-dev] [PATCH] enic: silence log message

From: Stephen Hemminger Silence is normal. drivers should speak only when spoken to and not be chatty. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_enic/enic_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c ind

[dpdk-dev] [PATCH] enic: silence log message

From: Stephen Hemminger Silence is normal. drivers should speak only when spoken to and not be chatty. Signed-off-by: Stephen Hemminger --- lib/librte_pmd_enic/enic_main.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/lib/librte_pmd_enic/enic_main.c b/lib/librte_pmd_enic/enic_main.c ind

[dpdk-dev] [PATCH v4 01/17] eal: add cpuset into per EAL thread lcore_config

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > The patch adds 'cpuset' into per-lcore configure 'lcore_config[]', > as the lcore no longer always 1:1 pinning with physical cpu. > The lcore now stands for a EAL thread rather than a logical cpu. > > It doesn't change the default behavior of 1:1

[dpdk-dev] [PATCH v4 02/17] eal: new eal option '--lcores' for cpu assignment

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > It supports one new eal long option '--lcores' for EAL thread cpuset > assignment. > > The format pattern: > --lcores='lcores[@cpus]<,lcores[@cpus]>' > lcores, cpus could be a single digit/range or a group. > '(' and ')' are necessary if i

[dpdk-dev] [PATCH v4 03/17] eal: fix wrong strnlen() return value in 32bit icc

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > The problem is that strnlen() here may return invalid value with 32bit icc. > (actually it returns it?s second parameter,e.g: sysconf(_SC_ARG_MAX)). > It starts to manifest hwen max_len parameter is > 2M and using icc ?m32 ?O2 > (or above). > >

[dpdk-dev] [PATCH v4 04/17] eal: add support parsing socket_id from cpuset

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > It returns the socket_id if all cpus in the cpuset belongs > to the same NUMA node, otherwise it will return SOCKET_ID_ANY. > > Signed-off-by: Cunming Liang > --- > lib/librte_eal/bsdapp/eal/eal_lcore.c | 7 + > lib/librte_eal/common/eal

[dpdk-dev] [PATCH v4 05/17] eal: new TLS definition and API declaration

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > 1. add two TLS *_socket_id* and *_cpuset* > 2. add two external API rte_thread_set/get_affinity > 3. add one internal API eal_thread_dump_affinity To me, it's a bit strage to add an API withtout the associated code. Maybe you have a good reason t

[dpdk-dev] [PATCH v4 06/17] eal: add eal_common_thread.c for common thread API

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > The API works for both EAL thread and none EAL thread. > When calling rte_thread_set_affinity, the *_socket_id* and > *_cpuset* of calling thread will be updated if the thread > successful set the cpu affinity. > > [...] > +int > +rte_thread_set_

[dpdk-dev] [PATCH v4 07/17] eal: add rte_gettid() to acquire unique system tid

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > The rte_gettid() wraps the linux and freebsd syscall gettid(). > It provides a persistent unique thread id for the calling thread. > It will save the unique id in TLS on the first time. > > [...] > > +/** > + * A wrap API for syscall gettid. > +

[dpdk-dev] [PATCH v4 08/17] eal: apply affinity of EAL thread by assigned cpuset

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > EAL threads use assigned cpuset to set core affinity during startup. > It keeps 1:1 mapping, if no '--lcores' option is used. > > [...] > > lib/librte_eal/bsdapp/eal/eal.c | 13 --- > lib/librte_eal/bsdapp/eal/eal_thread.c | 63 ++

[dpdk-dev] [PATCH v4 09/17] enic: fix re-define freebsd compile complain

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > Some macro already been defined by freebsd 'sys/param.h'. > > Signed-off-by: Cunming Liang > --- > lib/librte_pmd_enic/enic.h| 1 + > lib/librte_pmd_enic/enic_compat.h | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/lib/libr

[dpdk-dev] [PATCH v4 10/17] malloc: fix the issue of SOCKET_ID_ANY

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > Add check for rte_socket_id(), avoid get unexpected return like (-1). > > Signed-off-by: Cunming Liang > --- > lib/librte_malloc/malloc_heap.h | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_malloc/mal

[dpdk-dev] [PATCH v4 11/17] log: fix the gap to support non-EAL thread

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > For those non-EAL thread, *_lcore_id* is invalid and probably larger than > RTE_MAX_LCORE. > The patch adds the check and allows only EAL thread using EAL per thread log > level and log type. > Others shares the global log level. > > Signed-off

[dpdk-dev] [PATCH v4 12/17] eal: set _lcore_id and _socket_id to (-1) by default

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > For those none EAL thread, *_lcore_id* shall always be LCORE_ID_ANY. > The libraries using *_lcore_id* as index need to take care. > *_socket_id* always be SOCKET_ID_ANY unitl the thread changes the affinity unitl -> until > by rte_thread_set_af

[dpdk-dev] [PATCH v4 14/17] mempool: add support to non-EAL thread

Hi, On 02/02/2015 03:02 AM, Cunming Liang wrote: > For non-EAL thread, bypass per lcore cache, directly use ring pool. > It allows using rte_mempool in either EAL thread or any user pthread. > As in non-EAL thread, it directly rely on rte_ring and it's none preemptive. > It doesn't suggest to run