Hi Zhida
Please rework your patch and send a new version according to the comments from
Thomas! Commit log was missed in your patch.
Regards,
Helin
> -Original Message-
> From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of zhida zang
> Sent: Friday, November 21, 2014 4:07 PM
> To: d
On 24/11/14 5:47 am, "Neil Horman" wrote:
>On Sun, Nov 23, 2014 at 09:38:19PM +0530, Sujith Sankar wrote:
>> Signed-off-by: Sujith Sankar
>> ---
>> config/common_linuxapp | 5 +
>> lib/Makefile | 1 +
>> lib/librte_eal/linu
On 11/23/2014 9:22 PM, Chao Zhu wrote:
> This patch adds architecture specific byte order operations for IBM Power
> architecture. Power architecture support both big endian and little
> endian. This patch also adds a RTE_ARCH_BIG_ENDIAN micro.
>
> Signed-off-by: Chao Zhu
> ---
> config/defconfig
On 11/10/2014 2:42 PM, Xie, Huawei wrote:
>
>> -Original Message-
>> From: Zhang, Helin
>> Sent: Sunday, November 09, 2014 10:09 PM
>> To: Xie, Huawei; dev at dpdk.org
>> Subject: RE: [dpdk-dev] [PATCH v2 1/2] lib/librte_pmd_i40e: set vlan filter
>> fix
>>
>>
>>
>>> -Original Message--
Hello Sujith,
On Sun, Nov 23, 2014 at 5:08 PM, Sujith Sankar wrote:
> diff --git a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> b/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> index c776ddc..6bf8f2e 100644
> --- a/lib/librte_eal/linuxapp/eal/eal_pci_vfio.c
> +++ b/lib/librte_eal/linuxapp/eal/eal_
Hi friends,
I wanted to know how to install dpdk on virtual machine and how to get
virtual intel dpdk NIC card(virthal hardware)
in virtual machine if anybody know about it please reply me.
Regards...
Anand
On Sat, Nov 22, 2014 at 08:35:17PM -0500, Neil Horman wrote:
> On Sat, Nov 22, 2014 at 10:43:39PM +0100, Thomas Monjalon wrote:
> > From: Didier Pallard
> >
> > In current version, used cores can only be specified using a bitmask.
> > It will now be possible to specify cores in 2 different ways:
On Mon, Nov 24, 2014 at 05:45:54AM +, Sujith Sankar (ssujith) wrote:
>
>
> On 24/11/14 5:47 am, "Neil Horman" wrote:
>
> >On Sun, Nov 23, 2014 at 09:38:19PM +0530, Sujith Sankar wrote:
> >> Signed-off-by: Sujith Sankar
> >> ---
> >> config/common_linuxapp | 5 +
On 5 November 2014 at 14:00, Thomas Monjalon
wrote:
> It seems to be close to the bifurcated driver needs.
> Not sure if it can solve the security issues if there is no dedicated MMU
> in the NIC.
>
> I feel we should sum up pros and cons of
> - igb_uio
> - uio_pci_generic
>
v7:
- Fixes for checkpatch issues and typo fixes
- Removed patch "test app: adding support for generating variable sized" as this
was already committed in commit aca4360340f169dcc11b1a9be955b44de8b9f6eb
v6:
- Re-based to dpdk.org addressing associated issues for MBUF_REFCNT
- Added details to te
Signed-off-by: Declan Doherty
---
lib/librte_pmd_bond/rte_eth_bond_pmd.c | 65 +--
1 files changed, 36 insertions(+), 29 deletions(-)
diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c
b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
index de0cd56..f2fe930 100644
--- a/l
Adding support for lsc interrupt from bonded device to link
bonding library with supporting unit tests in the test application.
Signed-off-by: Declan Doherty
---
app/test/test_link_bonding.c | 213 +++-
lib/librte_pmd_bond/rte_eth_bond_api.c |4 +
lib/l
Signed-off-by: Declan Doherty
---
lib/librte_pmd_bond/rte_eth_bond_pmd.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c
b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
index f2fe930..6e770af 100644
--- a/lib/librte_pmd_bond/rte_
Signed-off-by: Declan Doherty
---
app/test-pmd/cmdline.c |2 +-
app/test-pmd/testpmd.c |3 ++-
app/test-pmd/testpmd.h |2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 4c3fc76..be12c13 100644
--- a/app/test-pmd
Signed-off-by: Declan Doherty
---
app/test/packet_burst_generator.c | 11 +-
app/test/packet_burst_generator.h | 15 +-
app/test/test_link_bonding.c | 435 ++--
app/test/virtual_pmd.c | 78 +--
app/test/virtual_pmd.h
Signed-off-by: Declan Doherty
---
app/test-pmd/cmdline.c | 63 +
app/test/test.h |7 +-
app/test/test_link_bonding.c| 265 ---
app/test/virtual_pmd.c | 17 +-
app/test/virtual_pmd.h
Signed-off-by: Declan Doherty
---
app/test/test_link_bonding.c | 2604 +-
1 files changed, 1052 insertions(+), 1552 deletions(-)
diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
index f428193..206b10a 100644
--- a/app/test/test_lin
Hi Bruce and Neil,
2014-11-24 11:28, Bruce Richardson:
> On Sat, Nov 22, 2014 at 08:35:17PM -0500, Neil Horman wrote:
> > On Sat, Nov 22, 2014 at 10:43:39PM +0100, Thomas Monjalon wrote:
> > > From: Didier Pallard
> > >
> > > In current version, used cores can only be specified using a bitmask.
On Mon, Nov 24, 2014 at 02:19:16PM +0100, Thomas Monjalon wrote:
> Hi Bruce and Neil,
>
> 2014-11-24 11:28, Bruce Richardson:
> > On Sat, Nov 22, 2014 at 08:35:17PM -0500, Neil Horman wrote:
> > > On Sat, Nov 22, 2014 at 10:43:39PM +0100, Thomas Monjalon wrote:
> > > > From: Didier Pallard
> > >
> > > > Do you want to burn an option letter on that? It seems like it
> > > > might be better to search the string for 0x and base the selection
> > > > of bitmap of list parsing based on its presence or absence.
> >
> > It was the initial proposal (in April):
> > http://dpdk.org/ml/archives/
Hope summary below could answer your questions.
From: lukego at gmail.com [mailto:luk...@gmail.com] On Behalf Of Luke Gorrie
Sent: Monday, November 24, 2014 7:58 PM
To: Thomas Monjalon
Cc: Zhou, Danny; dev at dpdk.org; Fastabend, John R
Subject: Re: [dpdk-dev] bifurcated driver
On 5 November 2014
On Mon, Nov 24, 2014 at 01:37:03PM +, Burakov, Anatoly wrote:
> > > > > Do you want to burn an option letter on that? It seems like it
> > > > > might be better to search the string for 0x and base the selection
> > > > > of bitmap of list parsing based on its presence or absence.
> > >
> > >
On Sun, Nov 23, 2014 at 08:22:16PM -0500, Chao Zhu wrote:
> IBM Power processor doesn't have CPU flag hardware registers. This patch
> uses aux vector software register to get CPU flags and add CPU flag
> checking support for IBM Power architecture.
>
> Signed-off-by: Chao Zhu
> ---
> app/test/t
The index.html file for each of the "guide" docs had a hard-coded
date value in them of June 2014. Rather than update each of these
for each revision, just use the |today| directive to insert the date
at which the document was generated.
Signed-off-by: Bruce Richardson
---
doc/guides/freebsd_gsg
This patch set updates the FreeBSD GSG for 1.8, mainly by
reworking the document to have installation via the ports
collection as the recommended installation path. Other
adjustments in the set involve updating all docs to use
an auto-generated, rather than hard-coded date, and to have
the FreeBSD
On Mon, Nov 24, 2014 at 02:23:51PM +, Bruce Richardson wrote:
> This patch set updates the FreeBSD GSG for 1.8, mainly by
> reworking the document to have installation via the ports
> collection as the recommended installation path. Other
> adjustments in the set involve updating all docs to us
On 11/24/2014 5:28 AM, Bruce Richardson wrote:
> On Mon, Nov 24, 2014 at 02:19:16PM +0100, Thomas Monjalon wrote:
>> Hi Bruce and Neil,
>>
>> 2014-11-24 11:28, Bruce Richardson:
>>> On Sat, Nov 22, 2014 at 08:35:17PM -0500, Neil Horman wrote:
On Sat, Nov 22, 2014 at 10:43:39PM +0100, Thomas M
Hello Chao,
On Mon, Nov 24, 2014 at 2:22 AM, Chao Zhu
wrote:
> The set of patches add IBM Power architecture to the DPDK. It adds the
> required support to the
> EAL library. This set of patches doesn't support full DPDK function on
> Power processors. So a
> separate common configuration file i
Chao,
I think there are two remaining issues, in
lib/librte_eal/linuxapp/eal/eal.c
and lib/librte_eal/linuxapp/eal/eal_hugepage_info.c.
I will send a patch in reply to this patch.
I think it can be integrated into your patchset.
Thanks.
--
David Marchand
On Mon, Nov 24, 2014 at 2:22 AM, Chao Z
RTE_ARCH_X86_64 can not be used as a way to determine if we are building for
64bits cpus. Instead, RTE_ARCH_64 should be used.
Signed-off-by: David Marchand
---
lib/librte_eal/linuxapp/eal/eal.c |2 +-
lib/librte_eal/linuxapp/eal/eal_hugepage_info.c |2 +-
2 files changed,
2014-11-24 14:43, Bruce Richardson:
> On Mon, Nov 24, 2014 at 02:23:51PM +, Bruce Richardson wrote:
> > This patch set updates the FreeBSD GSG for 1.8, mainly by
> > reworking the document to have installation via the ports
> > collection as the recommended installation path. Other
> > adjustme
Hi Declan,
There are still 2 kind of errors reported by checkpatch:
- 14 occurrences of this typo:
WARNING:TYPO_SPELLING: 'interupt' may be misspelled - perhaps 'interrupt'?
- 6 occurences of missing space:
WARNING:MISSING_SPACE: break quoted strings at a space character
Example:
#2016: FILE: lib
> This set of patches fixes bugs in the packet framework. Some of the
> bugs occur in corner cases (i.e. when a lookup is performed on a few
> packets or when buckets are in extended states) while others can cause
> memory to be accessed beyond what is reserved during initialization
> time.
>
> Ba
2014-10-01 11:12, Neil Horman:
> On Wed, Oct 01, 2014 at 03:20:22PM +0100, Pawel Wodkowski wrote:
> > v3:
> > Set rte_errno inside rte_alarm_cancel() to inform caller about canceling
> > result.
> >
> > v2:
> > Eliminate a race between rte_alarm_set() used in context of executing
> > cal
On Mon, Nov 24, 2014 at 04:25:05PM +0100, Thomas Monjalon wrote:
> 2014-11-24 14:43, Bruce Richardson:
> > On Mon, Nov 24, 2014 at 02:23:51PM +, Bruce Richardson wrote:
> > > This patch set updates the FreeBSD GSG for 1.8, mainly by
> > > reworking the document to have installation via the port
> data is not an mbuf field anymore.
>
> Signed-off-by: Sergio Gonzalez Monroy
Acked-by: Thomas Monjalon
Note: git history is better with commit references in commit log.
Added "Since commit 08b563ffb19 ("mbuf: replace data pointer by an offset"),"
Applied
Thanks
--
Thomas
The FreeBSD GSG rst files had very inconsistent line lengths for text
within paragraph blocks. Sometimes a line would be very short, while often
lines would be quite long.
This patch adjusts the formatting of the rst files so that lines break
at approx the 80-character mark, as is standard in the D
David,
My email server just come back. Sorry for the delay.
I'm running the patchcheck and I'll send out the updates later.
Thanks !
Quoting David Marchand :
> Hello Chao,
>
> On Mon, Nov 24, 2014 at 2:22 AM, Chao Zhu
> wrote:
>
>> The set of patches add IBM Power architecture to the DPDK. It a
Since the DPDK is now part of the BSD ports collection, we should
recommend installing from ports as the best way to get it up and
running.
In order to achieve this, while still keeping the document readable, the
chapter on system requirements has been moved to instead be a section
within the chapt
> DPDK QAT app was using the old "data" field in mbuf,
> so it has been subtituted with rte_pktmbuf_mtod function.
>
> Signed-off-by: Pablo de Lara
Acked-by: Thomas Monjalon
Commit reference 08b563ffb19 ("mbuf: replace data pointer by an offset") added.
Applied
Thanks
--
Thomas
Hi David,
During the testing, I saw that the length field was 0. ENIC PMD validates the
length of the BAR against a max value.
In order to get the length in the resource structure, I added this statement.
Thanks,
-Sujith
From: David Marchand mailto:david.march...@6wind.com>>
Date: Monday, 24 N
> > Some features of the cmdline were broken in FreeBSD as a result of
> > termios not being compiled.
> >
> > Signed-off-by: Sergio Gonzalez Monroy
>
> Acked-by: Bruce Richardson
Applied
Thanks
--
Thomas
> eal_flags and multiprocess unit tests use --file-prefix option
> which is not supported in FreeBSD, so it has been removed
> if compiled for this OS
>
> Signed-off-by: Pablo de Lara
Applied
Thanks
--
Thomas
> > This patch fixes two occurances where a call to strncmp had the closing
> > brace in the wrong place. Changing this form:
> > if (strncmp(X,Y,sizeof(X) != 0))
> > which does a comparison of length 1, to
> > if (strncmp(X,Y,sizeof(X)) != 0)
> > which does the correct length comparison an
> set link-up and set link-down were not included
> in the help command.
>
> Signed-off-by: Pablo de Lara
Acked-by: Thomas Monjalon
Applied
Thanks
--
Thomas
Quoting David Marchand :
> RTE_ARCH_X86_64 can not be used as a way to determine if we are building for
> 64bits cpus. Instead, RTE_ARCH_64 should be used.
>
> Signed-off-by: David Marchand
> ---
> lib/librte_eal/linuxapp/eal/eal.c |2 +-
> lib/librte_eal/linuxapp/eal/eal_huge
Burn, it is not like we are going to add a huge number of new options in the
future and run out of letters.
> On Nov 24, 2014, at 8:52 AM, Venkatesan, Venky intel.com> wrote:
>
>
> On 11/24/2014 5:28 AM, Bruce Richardson wrote:
>> On Mon, Nov 24, 2014 at 02:19:16PM +0100, Thomas Monjalon wrote
On 24/11/14 5:03 pm, "Neil Horman" wrote:
>On Mon, Nov 24, 2014 at 05:45:54AM +, Sujith Sankar (ssujith) wrote:
>>
>>
>> On 24/11/14 5:47 am, "Neil Horman" wrote:
>>
>> >On Sun, Nov 23, 2014 at 09:38:19PM +0530, Sujith Sankar wrote:
>> >> Signed-off-by: Sujith Sankar
>> >> ---
>> >> c
Mmm, I am not that familiar with vfio code, but I would say that there is
something buggy in pci_vfio_map_resource() when compared
to pci_uio_map_resource().
Is not there a problem with finding the right index of dev->mem_resource[]
array ?
--
David Marchand
On Mon, Nov 24, 2014 at 4:51 PM, Su
> This is a Linux-specific virtual PMD driver backed by an AF_PACKET
> socket. This implementation uses mmap'ed ring buffers to limit copying
> and user/kernel transitions. The PACKET_FANOUT_HASH behavior of
> AF_PACKET is used for frame reception. In the current implementation,
> Tx and Rx queu
Hey, sorry about that, I submitted the patchset without the typo fix. I'll
resubmit the patchset now.
What version of checkpatch are you using, I don't get any warning for the
missing spaces for the
version of the script with kernel 3.15 on Fedora
Thanks
Declan
> -Original Message-
> F
v2 changes:
New version handles race issues with setting/cancelin callbacks,
fixes promiscus mode setting in mode 4 and some other minor errors in mode 4
implementation.
v3 changes:
This is a rework of previous patchset. Basic functionality is the same but
contain following changes:
- use one glob
From: Pawel Wodkowski
Signed-off-by: Pawel Wodkowski
---
app/test-pmd/cmdline.c | 28 +++--
app/test-pmd/csumonly.c |9
app/test-pmd/icmpecho.c | 17 ++-
app/test-pmd/iofwd.c|9
app/test-pmd/macfwd-retry.c |
From: Pawel Wodkowski
Signed-off-by: Pawel Wodkowski
---
lib/librte_ether/rte_ether.h |1 +
lib/librte_pmd_bond/Makefile |2 +
lib/librte_pmd_bond/rte_eth_bond.h|5 +
lib/librte_pmd_bond/rte_eth_bond_8023ad.c | 1218
David,
ENIC PMD needs info about BAR0 only, and vfio map routine puts it at index 0.
So, it didn?t pose trouble.
Regards,
-Sujith
From: David Marchand mailto:david.march...@6wind.com>>
Date: Monday, 24 November 2014 9:45 pm
To: "Sujith Sankar (ssujith)" mailto:ssujith at
cisco.com>>
Cc: "dev
v8:
- Missing typo fix
- Missing whitespace
v7:
- Fixes for checkpatch issues and typo fixes
- Removed patch "test app: adding support for generating variable sized" as this
was already committed in commit aca4360340f169dcc11b1a9be955b44de8b9f6eb
v6:
- Re-based to dpdk.org addressing associated
Signed-off-by: Declan Doherty
---
lib/librte_pmd_bond/rte_eth_bond_pmd.c | 65 +--
1 files changed, 36 insertions(+), 29 deletions(-)
diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c
b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
index de0cd56..f2fe930 100644
--- a/l
Signed-off-by: Declan Doherty
---
lib/librte_pmd_bond/rte_eth_bond_pmd.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/lib/librte_pmd_bond/rte_eth_bond_pmd.c
b/lib/librte_pmd_bond/rte_eth_bond_pmd.c
index f2fe930..6e770af 100644
--- a/lib/librte_pmd_bond/rte_
Signed-off-by: Declan Doherty
---
app/test/packet_burst_generator.c | 11 +-
app/test/packet_burst_generator.h | 15 +-
app/test/test_link_bonding.c | 435 ++--
app/test/virtual_pmd.c | 78 +--
app/test/virtual_pmd.h
Adding support for lsc interrupt from bonded device to link
bonding library with supporting unit tests in the test application.
Signed-off-by: Declan Doherty
---
app/test/test_link_bonding.c | 213 +++-
lib/librte_pmd_bond/rte_eth_bond_api.c |4 +
lib/l
Signed-off-by: Declan Doherty
---
app/test-pmd/cmdline.c |2 +-
app/test-pmd/testpmd.c |3 ++-
app/test-pmd/testpmd.h |2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c
index 4c3fc76..be12c13 100644
--- a/app/test-pmd
Signed-off-by: Declan Doherty
---
app/test-pmd/cmdline.c | 63 +
app/test/test.h |7 +-
app/test/test_link_bonding.c| 265 ---
app/test/virtual_pmd.c | 17 +-
app/test/virtual_pmd.h
Signed-off-by: Declan Doherty
---
app/test/test_link_bonding.c | 2576 +---
lib/librte_pmd_bond/rte_eth_bond_pmd.c | 16 +-
2 files changed, 1046 insertions(+), 1546 deletions(-)
diff --git a/app/test/test_link_bonding.c b/app/test/test_link_bonding.c
ind
On Mon, Nov 24, 2014 at 10:12:33AM -0600, Roger Keith Wiles wrote:
> Burn, it is not like we are going to add a huge number of new options in the
> future and run out of letters.
>
No, but what about the application authors that need to accomodate all of the
dpdk command line options as well?
Nei
> On Nov 24, 2014, at 11:04 AM, Neil Horman wrote:
>
> On Mon, Nov 24, 2014 at 10:12:33AM -0600, Roger Keith Wiles wrote:
>> Burn, it is not like we are going to add a huge number of new options in the
>> future and run out of letters.
>>
> No, but what about the application authors that need
> On Mon, Nov 24, 2014 at 10:12:33AM -0600, Roger Keith Wiles wrote:
> > Burn, it is not like we are going to add a huge number of new options in the
> future and run out of letters.
> >
> No, but what about the application authors that need to accomodate all of
> the dpdk command line options as w
From: Pawel Wodkowski
v2 changes:
New version handles race issues with setting/cancelin callbacks,
fixes promiscus mode setting in mode 4 and some other minor errors in mode 4
implementation.
v3 changes:
This is a rework of previous patchset. Basic functionality is the same but
contain following
From: Pawel Wodkowski
Signed-off-by: Pawel Wodkowski
---
lib/librte_ether/rte_ether.h |1 +
lib/librte_pmd_bond/Makefile |2 +
lib/librte_pmd_bond/rte_eth_bond.h|5 +
lib/librte_pmd_bond/rte_eth_bond_8023ad.c | 1218 +
From: Pawel Wodkowski
Signed-off-by: Pawel Wodkowski
---
app/test-pmd/cmdline.c | 28 ++--
app/test-pmd/csumonly.c |9
app/test-pmd/icmpecho.c | 21 +-
app/test-pmd/iofwd.c|9
app/test-pmd/macfwd-retry.c |
On Mon, Nov 24, 2014 at 05:11:16PM +, Burakov, Anatoly wrote:
> > On Mon, Nov 24, 2014 at 10:12:33AM -0600, Roger Keith Wiles wrote:
> > > Burn, it is not like we are going to add a huge number of new options in
> > > the
> > future and run out of letters.
> > >
> > No, but what about the appl
On Mon, Nov 24, 2014 at 04:12:48PM +, Sujith Sankar (ssujith) wrote:
>
>
> On 24/11/14 5:03 pm, "Neil Horman" wrote:
>
> >On Mon, Nov 24, 2014 at 05:45:54AM +, Sujith Sankar (ssujith) wrote:
> >>
> >>
> >> On 24/11/14 5:47 am, "Neil Horman" wrote:
> >>
> >> >On Sun, Nov 23, 2014 at
2014-11-24 16:24, Doherty, Declan:
> Hey, sorry about that, I submitted the patchset without the typo fix. I'll
> resubmit the patchset now.
> What version of checkpatch are you using, I don't get any warning for the
> missing spaces for the
> version of the script with kernel 3.15 on Fedora
I u
2014-11-24 17:13, Michal Jastrzebski:
> From: Pawel Wodkowski
>
> Signed-off-by: Pawel Wodkowski
As I've already requested, we need some explanations.
The minimum is to explain what is mode 4 or give inputs.
It won't be integrated without it. Wednesday is the deadline for this stuff.
> ---
>
Declan,
There are still some missing spaces:
WARNING:MISSING_SPACE: break quoted strings at a space character
#2002: FILE: lib/librte_pmd_bond/rte_eth_bond_pmd.c:1406:
+ "Invalid lsc polling interval value
specified for bonded"
+
2014-11-24 19:32, Thomas Monjalon:
> I'm fixing it for you because I'm losing confidence all bonding patches will
> be ready on time.
I've just understood what happened.
I think it's a wrong git manipulation: the fixes were squashed in the last
commit, so the patch 6/7 was still having issues.
--
2014-11-24 16:33, Declan Doherty:
> v8:
> - Missing typo fix
> - Missing whitespace
>
> v7:
> - Fixes for checkpatch issues and typo fixes
> - Removed patch "test app: adding support for generating variable sized" as
> this
> was already committed in commit aca4360340f169dcc11b1a9be955b44de8b9f
There is no parameter delay_ms in *_delay_get functions.
Signed-off-by: Thomas Monjalon
---
lib/librte_pmd_bond/rte_eth_bond.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/lib/librte_pmd_bond/rte_eth_bond.h
b/lib/librte_pmd_bond/rte_eth_bond.h
index 2ed4f7c..085500b 100644
--- a/lib/lib
> -Original Message-
> From: Qiu, Michael
> Sent: Monday, November 24, 2014 1:33 AM
> To: Xie, Huawei; Zhang, Helin; dev at dpdk.org
> Subject: Re: [dpdk-dev] [PATCH v2 1/2] lib/librte_pmd_i40e: set vlan filter
> fix
>
> On 11/10/2014 2:42 PM, Xie, Huawei wrote:
> >
> >> -Original M
> > As e1000, ixgbe and i40e hardware use different sizes of redirection
> > table in PF or VF, ethdev and PMDs need to be reworked to support
> > multiple sizes of that table. In addition, commands in testpmd also
> > need to be reworked to support these changes.
> >
> > v2 changes:
> > * Reorgan
The parameters port_id didn't match with comments about port.
Signed-off-by: Thomas Monjalon
---
lib/librte_ether/rte_ethdev.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h
index fec4d4c..78a9d37 100644
--- a
Helin,
I fixed these errors before applying:
WARNING:MISSING_SPACE: break quoted strings at a space character
#134: FILE: lib/librte_pmd_i40e/i40e_ethdev_vf.c:1705:
+ "(%d) doesn't match the number of hardware can"
+ "support (%d)\n", reta_size, ETH_RSS
81 matches
Mail list logo
