[dpdk-dev] l2fwd application - packets not getting forwarded

2014-06-13 Thread Raj Ravi
Hi, I am trying to run l2fwd application in ixgbe based network adapter. Followed the below steps: 1. Add hugepages in grub commandline. 1024 pages of 2 MB allocated. 2. verify hugepages support in /proc/meminfo. 3.mounted huge pages as below: mount -t hugetlbfs nodev /mnt/huge 4. built DPDK envi

[dpdk-dev] l2fwd application - packets not getting forwarded

2014-06-13 Thread Raj Ravi
/Any help ? let me know if any additional info. is required. Thanks. On Fri, Jun 13, 2014 at 1:17 AM, Raj Ravi wrote: > Hi, > I am trying to run l2fwd application in ixgbe based network adapter. > > Followed the below steps: > 1. Add hugepages in grub commandline. 1024 pages of 2 MB allocated. >

[dpdk-dev] l2fwd application - packets not getting forwarded

2014-06-13 Thread Raj Ravi
Is there any requirement to modify l2fwd appliucation with updated mac address to make it work ? In one example, it is mentioned something similar. www.slideshare.net/hisaki/intel-dpdk-step-by-step-instructions Also, in order to make ping work it is necessary to add static entry for those IP add

[dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled

2014-06-13 Thread Ouyang, Changchun
Acked by Changchun Ouyang -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Friday, June 13, 2014 9:33 AM To: Stephen Hemminger Cc: dev at dpdk.org Subject: [dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled Remove useless message tha

[dpdk-dev] [PATCH 1/2] virtio: checkpatch cleanups

2014-06-13 Thread Ouyang, Changchun
Acked by Changchun, Ouyang -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Stephen Hemminger Sent: Friday, June 13, 2014 9:33 AM To: dev at dpdk.org Subject: [dpdk-dev] [PATCH 1/2] virtio: checkpatch cleanups This fixes style problems reported by checkpatch includ

[dpdk-dev] [PATCH 1/2] virtio: checkpatch cleanups

2014-06-13 Thread Thomas Monjalon
> This fixes style problems reported by checkpatch including: > * extra whitespace > * spaces before tabs > * strings broken across lines > * excessively long lines > * missing spaces after keywords > * unnecessary paren's in return statements > > Signed-off-by: Stephen Hemminger Ack

[dpdk-dev] [PATCH 2/2] virtio: fix build with debug enabled

2014-06-13 Thread Thomas Monjalon
2014-06-12 18:32, Stephen Hemminger: > Remove useless message that breaks if VIRTIO_DEBUG_DRIVER is defined. > virtio_ethdev.c:224:2: error: dereferencing type-punned pointer will break > strict-aliasing rules [-Werror=strict-aliasing] > > Signed-off-by: Stephen Hemminger Acked-by: Changchun Ou

[dpdk-dev] [PATCHv3 0/5] ACL library

2014-06-13 Thread Konstantin Ananyev
The ACL library is used to perform an N-tuple search over a set of rules with multiple categories and find the best match (highest priority) for each category. This code was previously released under a proprietary license, but is now being released under a BSD license to allow its integration with

[dpdk-dev] [PATCHv3 1/5] Add ACL library (librte_acl) into DPDK

2014-06-13 Thread Konstantin Ananyev
The ACL library is used to perform an N-tuple search over a set of rules with multiple categories and find the best match for each category. Signed-off-by: Konstantin Ananyev --- config/common_linuxapp |6 + lib/librte_acl/Makefile | 60 + lib/librte_acl/acl.h

[dpdk-dev] [PATCHv3 2/5] acl: update UT to reflect latest changes in the librte_acl

2014-06-13 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- app/test/test_acl.c | 216 --- 1 files changed, 135 insertions(+), 81 deletions(-) diff --git a/app/test/test_acl.c b/app/test/test_acl.c index 97cf1fb..5abe36f 100644 --- a/app/test/test_acl.c +++ b/app/test/

[dpdk-dev] [PATCHv3 3/5] acl: New test-acl application

2014-06-13 Thread Konstantin Ananyev
Introduce test-acl: Usage example and main test application for the ACL library. Provides IPv4/IPv6 5-tuple classification. Signed-off-by: Konstantin Ananyev --- app/Makefile |1 + app/test-acl/Makefile | 45 +++ app/test-acl/main.c | 1029 +++

[dpdk-dev] [PATCHv3 5/5] acl: add doxygen configuration and start page

2014-06-13 Thread Konstantin Ananyev
Signed-off-by: Konstantin Ananyev --- doc/doxy-api-index.md |3 ++- doc/doxy-api.conf |3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md index 6e75a6e..83303a1 100644 --- a/doc/doxy-api-index.md +++ b/doc/doxy-api-index

[dpdk-dev] [PATCHv3 4/5] acl: New sample l3fwd-acl

2014-06-13 Thread Konstantin Ananyev
Demonstrates the use of the ACL library in the DPDK application to implement packet classification and L3 forwarding. Signed-off-by: Konstantin Ananyev --- examples/Makefile |1 + examples/l3fwd-acl/Makefile | 56 ++ examples/l3fwd-acl/main.c | 2140

[dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter

2014-06-13 Thread Vladimir Medvedkin
Hi all, The 82599 datasheet (p. 284 and p.287) has only recommendations and only when possible about assign rx queue not used by RSS/DCB. I do not see any serious restrictions do not assign the rx queue used by RSS/DCB. For cases with only 1 queue if I understand correctly this patch http://dpdk.o

[dpdk-dev] [PATCHv3 0/5] ACL library

2014-06-13 Thread Thomas Monjalon
Hi Konstantin, > Konstantin Ananyev (5): > Add ACL library (librte_acl) into DPDK > acl: update UT to reflect latest changes in the librte_acl > acl: New test-acl application > acl: New sample l3fwd-acl > acl: add doxygen configuration and start page > > v2 fixes: > * Fixed several chec

[dpdk-dev] [PATCHv3 0/5] ACL library

2014-06-13 Thread Ananyev, Konstantin
Hi Thomas, These changes would require a lot of changes inside ACL library. As I said in cover letter, ACL library was part of IPL code for a while (nearly a year). I don't really want to make significant changes in it just before the release without really good reason - bugs found. Thanks Konsta

[dpdk-dev] [PATCH 05/15 v3] ring: Convert to use of PMD_REGISTER_DRIVER and fix linking

2014-06-13 Thread De Lara Guarch, Pablo
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Neil Horman > Sent: Thursday, April 17, 2014 4:17 PM > To: dev at dpdk.org > Subject: [dpdk-dev] [PATCH 05/15 v3] ring: Convert to use of > PMD_REGISTER_DRIVER and fix linking > > convert the ring driver to use

[dpdk-dev] [PATCH v2 0/7] add mtu and flow control handlers

2014-06-13 Thread David Marchand
This patchset introduces 3 new ethdev operations: flow control parameters retrieval and mtu get/set operations. Changes since v1: - compute min rx buffer size at ethdev level (to simplify pmd mtu checks) - introduce enable_scatter rx mode so that we can advise pmd to configure scatter mode - rew

[dpdk-dev] [PATCH v2 1/7] ethdev: retrieve flow control configuration

2014-06-13 Thread David Marchand
From: Zijie Pan This patch adds a new function in ethdev api to retrieve current flow control configuration. This operation has been implemented for rte_em_pmd, rte_igb_pmd and rte_ixgbe_pmd. Signed-off-by: Zijie Pan Signed-off-by: David Marchand --- lib/librte_ether/rte_ethdev.c | 16

[dpdk-dev] [PATCH v2 2/7] ethdev: add autoneg parameter in flow ctrl accessors

2014-06-13 Thread David Marchand
Add autoneg field in flow control parameters. This makes it easier to understand why changing some parameters does not always have the expected result. Changing autoneg is not supported at the moment. Signed-off-by: David Marchand --- lib/librte_ether/rte_ethdev.h |1 + lib/librte_pmd

[dpdk-dev] [PATCH v2 3/7] ethdev: store min rx buffer size

2014-06-13 Thread David Marchand
This avoids code duplication in PMD when dealing with mtu changes. Signed-off-by: David Marchand --- lib/librte_ether/rte_ethdev.c | 19 ++- lib/librte_ether/rte_ethdev.h |3 +++ 2 files changed, 17 insertions(+), 5 deletions(-) diff --git a/lib/librte_ether/rte_ethdev.c b

[dpdk-dev] [PATCH v2 4/7] ethdev: introduce enable_scatter rx mode

2014-06-13 Thread David Marchand
We might want to be sure the scatter packets reception handler is selected in a pmd. This makes it possible to then change mtu later, without the need of restarting a port. It is then the pmd duty to tell it enabled the scatter reception handler by setting dev->data->scattered_rx to 1. Signed-off-

[dpdk-dev] [PATCH v2 5/7] ethdev: add mtu accessors

2014-06-13 Thread David Marchand
From: Samuel Gauthier This patch adds two new functions in ethdev api to retrieve current MTU and change MTU of a port. Only .mtu_set function is pmd specific. pmd should update its max_rx_pkt_len if needed. This operation has been implemented for rte_em_pmd, rte_igb_pmd and rte_ixgbe_pmd. Sign

[dpdk-dev] [PATCH v2 6/7] ixgbe: add set_mtu to ixgbevf

2014-06-13 Thread David Marchand
From: Ivan Boule The support of jumbo frames in the ixgbevf Poll Mode Driver of 10GbE 82599 VF functions consists in the following enhancements: - Implement the mtu_set function in the ixgbevf PMD, using the IXGBE_VF_SET_LPE request of the version 1.0 of the VF/PF mailbox API for this purpose.

[dpdk-dev] [PATCH v2 7/7] app/testpmd: allow to configure mtu

2014-06-13 Thread David Marchand
From: Ivan Boule Take avantage of the .set_mtu ethdev function and make it possible to configure MTU on devices using testpmd. Signed-off-by: Ivan Boule Signed-off-by: David Marchand --- app/test-pmd/cmdline.c | 54 app/test-pmd/config.c |

[dpdk-dev] [PATCH v2 1/4] Link Bonding Library

2014-06-13 Thread Doherty, Declan
> -Original Message- > From: Eric Kinzie [mailto:ehkinzie at gmail.com] > Sent: Monday, June 9, 2014 10:11 PM > To: Doherty, Declan > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/4] Link Bonding Library > > On Wed Jun 04 16:18:53 +0100 2014, Declan Doherty wrote: > > - Broadca

[dpdk-dev] [PATCH v2 0/4] Link Bonding Library

2014-06-13 Thread Doherty, Declan
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > Sent: Wednesday, June 11, 2014 5:33 PM > To: Doherty, Declan > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/4] Link Bonding Library > > Hi Declan, > > Do you think you can send another versio

[dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter

2014-06-13 Thread Wu, Jingjing
Hi, Vladimir Thanks a lot for your remarks. Yes, your understanding is correct, in non-IOV mode, we can use 64pool, per pool can has 2 queues when ETH_MQ_RX_VMDQ_ONLY. While in IOV mode, current DPDK version makes the number of queue to 1 by default. The pools logic makes sense, but I didn?t

[dpdk-dev] [PATCH v5 00/20] Add VFIO support to DPDK

2014-06-13 Thread Burakov, Anatoly
> This patchset adds support for using VFIO instead of IGB_UIO to map the > device BARs. > NAK, there's a small problem with FreeBSD, v6 is coming. Best regards, Anatoly Burakov DPDK SW Engineer

[dpdk-dev] [PATCH v3 0/5] Link Bonding PMD Library

2014-06-13 Thread Declan Doherty
This patch contains the initial release of the Link Bonding PMD Library Supporting bonding modes: 0 - Round Robin 1 - Active Backup 2 - Balance (Supporting 3 transmission polices) layer 2, layer 2+3, layer 3+4 3 - Broadcast Version 3 of this patch set add the following functionality

[dpdk-dev] [PATCH v3 2/5] Link Bonding PMD Library (librte_eal/librte_ether link bonding support changes)

2014-06-13 Thread Declan Doherty
Updating functionality in EAL to support adding link bonding devices via ???vdev option. Link bonding devices will be initialized after all physical devices have been probed and initialized. Signed-off-by: Declan Doherty --- lib/librte_eal/common/eal_common_dev.c | 66 ++

[dpdk-dev] [PATCH v3 5/5] Link Bonding PMD Library (Doxygen Additions)

2014-06-13 Thread Declan Doherty
Signed-off-by: Declan Doherty --- doc/doxy-api-index.md | 1 + doc/doxy-api.conf | 1 + 2 files changed, 2 insertions(+) diff --git a/doc/doxy-api-index.md b/doc/doxy-api-index.md index 6e75a6e..a4d2e57 100644 --- a/doc/doxy-api-index.md +++ b/doc/doxy-api-index.md @@ -36,6 +36,7 @@ API {#in

[dpdk-dev] [PATCH v3 1/5] Link Bonding PMD Library

2014-06-13 Thread Declan Doherty
Link Bonding Library (lib/librte_pmd_bond) initial release with support for Mode 0 - Round Robin Mode 1 - Active Backup Mode 2 - Balance -> Supports 3 transmit polices (layer 2, layer 2+3, layer 3+4) Mode 3 - Broadcast Signed-off-by: Declan Doherty --- config/common_bsdapp |

[dpdk-dev] [PATCH v3 3/5] Link Bonding PMD Library (Unit Test Suite)

2014-06-13 Thread Declan Doherty
Link bonding unit tests, including: - code to generate packet bursts for testing rx and tx functionality of bonded device - virtual/stubbed out ethdev for use as slave ethdev in testing Signed-off-by: Declan Doherty --- app/test/Makefile |4 +- app/test/commands.c

[dpdk-dev] [PATCH v3 4/5] Link Bonding PMD Library (testpmd link bonding API support)

2014-06-13 Thread Declan Doherty
Adding link bonding support to testpmd. - Includes the ability to create new bonded devices. - Add /remove bonding slave devices. - Interogate bonded device stats/configuration - Change bonding modes and select balance transmit polices Signed-off-by: Declan Doherty --- app/test-pmd/cmdline.c

[dpdk-dev] [PATCH v6 01/20] pci: move open() out of pci_map_resource, rename structs

2014-06-13 Thread Anatoly Burakov
Separating mapping code and calls to open. This is a preparatory work for VFIO patch since it'll need to map BARs too but it doesn't use path in mapped_pci_resource. Also, renaming structs to be more generic. --- lib/librte_eal/linuxapp/eal/eal_pci.c | 125 -- 1 fil

[dpdk-dev] [PATCH v6 06/20] igb_uio: make igb_uio compilation optional

2014-06-13 Thread Anatoly Burakov
Currently, igb_uio is always compiled. Some Linux distributions may not want to include igb_uio with DPDK, so we need to make sure that igb_uio compilation for Linuxapp targets can be optional. --- config/common_linuxapp | 1 + lib/librte_eal/linuxapp/Makefile | 2 ++ 2 files changed, 3

[dpdk-dev] [PATCH v6 03/20] pci: fixing errors in a previous commit found by checkpatch

2014-06-13 Thread Anatoly Burakov
--- lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 112 +++-- lib/librte_eal/linuxapp/eal/include/eal_pci_init.h | 2 +- 3 files changed, 63 insertions(+), 53 deletions(-) diff --git a/lib/librte_eal/linuxapp/eal

[dpdk-dev] [PATCH v6 08/20] vfio: add support for VFIO in Linuxapp targets

2014-06-13 Thread Anatoly Burakov
Add VFIO compilation option to common Linuxapp config. --- config/common_linuxapp | 1 + 1 file changed, 1 insertion(+) diff --git a/config/common_linuxapp b/config/common_linuxapp index 5f6b8f0..63ae903 100644 --- a/config/common_linuxapp +++ b/config/common_linuxapp @@ -124,6 +124,7 @@ CONFIG_R

[dpdk-dev] [PATCH v6 00/20] Add VFIO support to DPDK

2014-06-13 Thread Anatoly Burakov
This patchset adds support for using VFIO instead of IGB_UIO to map the device BARs. VFIO is a kernel 3.6+ driver allowing secure DMA from userspace by means of using IOMMU instead of working directly with physical memory like igb_uio does. Short summary: * Adding support for VFIO in EAL PCI code

[dpdk-dev] [PATCH v6 16/20] eal: make --no-huge use mmap instead of malloc

2014-06-13 Thread Anatoly Burakov
This makes it possible to run DPDK without hugepage memory when VFIO is used, as VFIO uses virtual addresses to set up DMA mappings. Technically, malloc is just fine, but we want to guarantee that memory will be page-aligned, so using mmap to be safe. --- lib/librte_eal/linuxapp/eal/eal_memory.c

[dpdk-dev] [PATCH v6 11/20] eal: remove -Wno-return-type for non-existent eal_hpet.c

2014-06-13 Thread Anatoly Burakov
eal_hpet.c was renamed to eal_timer.c and, thanks to code changes, does not need the -Wno-return-type any more. --- lib/librte_eal/linuxapp/eal/Makefile | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/librte_eal/linuxapp/eal/Makefile b/lib/librte_eal/linuxapp/eal/Makefile index 6e320ec..00

[dpdk-dev] [PATCH v6 07/20] igb_uio: Moved interrupt type out of igb_uio

2014-06-13 Thread Anatoly Burakov
Moving interrupt type enum out of igb_uio and renaming it to be more generic. Such a strange header naming and separation is done mostly to make coming virtio patches easier to port to dpdk.org tree. --- lib/librte_eal/common/Makefile | 1 + lib/librte_eal/common/include/rte_p

[dpdk-dev] [PATCH v6 14/20] pci: enable VFIO device binding

2014-06-13 Thread Anatoly Burakov
Add support for binding VFIO devices if RTE_PCI_DRV_NEED_MAPPING is set for this driver. Try VFIO first, if not mapped then try IGB_UIO too. --- lib/librte_eal/linuxapp/eal/eal_pci.c | 44 +-- 1 file changed, 42 insertions(+), 2 deletions(-) diff --git a/lib/librte

[dpdk-dev] [PATCH v6 05/20] pci: Rename RTE_PCI_DRV_NEED_IGB_UIO to RTE_PCI_DRV_NEED_MAPPING

2014-06-13 Thread Anatoly Burakov
Rename the RTE_PCI_DRV_NEED_IGB_UIO to be more generic. --- app/test/test_pci.c | 4 ++-- lib/librte_eal/bsdapp/eal/eal_pci.c | 2 +- lib/librte_eal/common/include/rte_pci.h | 4 ++-- lib/librte_eal/linuxapp/eal/eal_pci.c | 2 +- lib/librte_pmd_e1000/em_ethdev.c|

[dpdk-dev] [PATCH v6 12/20] vfio: create mapping code for VFIO

2014-06-13 Thread Anatoly Burakov
Adding code to support VFIO mapping (primary processes only). Most of the things are done via ioctl() calls on either /dev/vfio/vfio (the container) or a /dev/vfio/$GROUP_NR (IOMMU group). In a nutshell, the code does the following: 1. creates a VFIO container (an entity that allows sharing IOMMU

[dpdk-dev] [PATCH v6 17/20] test app: adding unit tests for VFIO EAL command-line parameter

2014-06-13 Thread Anatoly Burakov
Adding unit tests for VFIO interrupt type command-line parameter. We don't know if VFIO is compiled (eal_vfio.h header is internal to Linuxapp EAL), so we check this flag regardless. --- app/test/test_eal_flags.c | 36 1 file changed, 36 insertions(+) diff --g

[dpdk-dev] [PATCH v6 18/20] igb_uio: Removed PCI ID table from igb_uio

2014-06-13 Thread Anatoly Burakov
Removing PCI ID list to make igb_uio more similar to a generic driver like vfio-pci or pci_uio_generic. This is done to make it easier for the binding script to support multiple drivers. Note that since igb_uio no longer has a PCI ID list, it can now be bound to any device, not just those explicit

[dpdk-dev] [PATCH v6 10/20] interrupts: Add support for VFIO interrupts

2014-06-13 Thread Anatoly Burakov
Creating code to handle VFIO interrupts in EAL interrupts (supports all types of interrupts). --- lib/librte_eal/linuxapp/eal/eal_interrupts.c | 287 - .../linuxapp/eal/include/exec-env/rte_interrupts.h | 4 + 2 files changed, 286 insertions(+), 5 deletions(-) diff --g

[dpdk-dev] [PATCH v6 02/20] pci: move uio mapping code to a separate file

2014-06-13 Thread Anatoly Burakov
--- lib/librte_eal/linuxapp/eal/Makefile | 1 + lib/librte_eal/linuxapp/eal/eal_pci.c | 403 +--- lib/librte_eal/linuxapp/eal/eal_pci_uio.c | 421 + lib/librte_eal/linuxapp/eal/include/eal_pci_init.h | 66 4 files chan

[dpdk-dev] [PATCH v6 15/20] eal: added support for selecting VFIO interrupt type from EAL command-line

2014-06-13 Thread Anatoly Burakov
Unlike igb_uio, VFIO interrupt type is not set by kernel module parameters but is set up via ioctl() calls at runtime. This warrants a new EAL command-line parameter. It will have no effect if VFIO is not compiled, but will set VFIO interrupt type to either "legacy", "msi" or "msix" if VFIO support

[dpdk-dev] [PATCH v6 19/20] binding script: Renamed igb_uio_bind to dpdk_nic_bind

2014-06-13 Thread Anatoly Burakov
Renaming the igb_uio_bind script to dpdk_nic_bind to have a generic name since we're now supporting two drivers. --- tools/{igb_uio_bind.py => dpdk_nic_bind.py} | 47 - tools/setup.sh | 16 +- 2 files changed, 40 insertions(+), 23 de

[dpdk-dev] [PATCH v6 04/20] pci: distinguish between legitimate failures and non-fatal errors

2014-06-13 Thread Anatoly Burakov
Currently, EAL does not distinguish between actual failures and expected initialization errors. E.g. sometimes the driver fails to initialize because it was not supposed to be initialized in the first place, such as device not being managed by said driver. This patch makes EAL fail on actual initi

[dpdk-dev] [PATCH v6 09/20] vfio: add VFIO header

2014-06-13 Thread Anatoly Burakov
Adding a header that will determine if VFIO support should be compiled in. If VFIO is enabled in config (and it's enabled by default), then the header will also check for kernel version. If VFIO is enabled in config and if the kernel version is 3.6+, then VFIO_PRESENT will be defined. This is the m

[dpdk-dev] [PATCH v6 20/20] setup script: adding support for VFIO to setup.sh

2014-06-13 Thread Anatoly Burakov
Support for loading/unloading VFIO drivers, binding/unbinding devices to/from VFIO, also setting up correct userspace permissions. --- tools/setup.sh | 157 +++-- 1 file changed, 142 insertions(+), 15 deletions(-) diff --git a/tools/setup.sh b/t

[dpdk-dev] [PATCH v6 13/20] vfio: add multiprocess support.

2014-06-13 Thread Anatoly Burakov
Since VFIO cannot be used to map the same device twice, secondary processes receive the device/group fd's by means of communicating over a local socket. Only group and container fd's should be sent, as device fd's can be obtained via ioctl() calls' on the group fd. For multiprocess, VFIO distingui

[dpdk-dev] [PATCH v2 0/4] Link Bonding Library

2014-06-13 Thread Doherty, Declan
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Friday, June 6, 2014 3:54 PM > To: Doherty, Declan > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 0/4] Link Bonding Library > > On Fri, Jun 06, 2014 at 08:23:31AM +, Doherty, Declan wrote: > >

[dpdk-dev] [PATCH v2 0/4] Link Bonding Library

2014-06-13 Thread Neil Horman
On Fri, Jun 13, 2014 at 02:56:47PM +, Doherty, Declan wrote: > > -Original Message- > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Friday, June 6, 2014 3:54 PM > > To: Doherty, Declan > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v2 0/4] Link Bonding Libr

[dpdk-dev] [PATCH v2 0/4] Link Bonding Library

2014-06-13 Thread Thomas Monjalon
2014-06-13 14:08, Doherty, Declan: > From: Thomas Monjalon [mailto:thomas.monjalon at 6wind.com] > > Do you think you can send another version of your serie soon? > > Some comments need to be addressed. > > > > 2 formatting comments: > > - I saw some strange alignments of comments > > - you should

[dpdk-dev] [PATCH v3 0/5] Link Bonding PMD Library

2014-06-13 Thread Neil Horman
On Fri, Jun 13, 2014 at 03:41:57PM +0100, Declan Doherty wrote: > This patch contains the initial release of the Link Bonding PMD Library > > Supporting bonding modes: > 0 - Round Robin > 1 - Active Backup > 2 - Balance (Supporting 3 transmission polices) > layer 2, layer 2+3, layer 3+4 >

[dpdk-dev] Testing memnic for VM to VM transfer

2014-06-13 Thread John Joyce (joycej)
Hi everyone: We are interested in testing the performance of the memnic driver posted at http://dpdk.org/browse/memnic/refs/. We want to compare its performance compared to other techniques to transfer packets between the guest and the kernel, predominately for VM to VM transfers.

[dpdk-dev] [PATCH 2/7] rte_ring: make ring tailq completely local

2014-06-13 Thread Anatoly Burakov
--- lib/librte_eal/linuxapp/eal/eal_ivshmem.c | 14 +++-- lib/librte_ring/Makefile | 4 ++-- lib/librte_ring/rte_ring.c| 33 +++ lib/librte_ring/rte_ring.h| 2 -- 4 files changed, 39 insertions(+), 14 deletions(

[dpdk-dev] [PATCH 7/7] rte_lpm6: make lpm6 tailq fully local

2014-06-13 Thread Anatoly Burakov
--- lib/librte_lpm/rte_lpm6.c | 55 +-- 1 file changed, 44 insertions(+), 11 deletions(-) diff --git a/lib/librte_lpm/rte_lpm6.c b/lib/librte_lpm/rte_lpm6.c index 56c74a1..36cb9fc 100644 --- a/lib/librte_lpm/rte_lpm6.c +++ b/lib/librte_lpm/rte_lpm6.c @@

[dpdk-dev] [PATCH 5/7] rte_mempool: make mempool tailq fully local

2014-06-13 Thread Anatoly Burakov
--- lib/librte_mempool/Makefile | 3 ++- lib/librte_mempool/rte_mempool.c | 37 - lib/librte_mempool/rte_mempool.h | 2 -- 3 files changed, 30 insertions(+), 12 deletions(-) diff --git a/lib/librte_mempool/Makefile b/lib/librte_mempool/Makefile index c79

[dpdk-dev] [PATCH 0/7] Make DPDK tailqs fully local

2014-06-13 Thread Anatoly Burakov
This issue was reported by OVS-DPDK project, and the fix should go to upstream DPDK. This is not memnic-related - this is to do with DPDK's rte_ivshmem library. Every DPDK data structure has a corresponding TAILQ reserved for it in the runtime config file. Those TAILQs are fully local to the proce

[dpdk-dev] [PATCH 4/7] rte_fbk_hash: make rte_fbk_hash tailq fully local

2014-06-13 Thread Anatoly Burakov
--- lib/librte_hash/rte_fbk_hash.c | 66 +- lib/librte_hash/rte_fbk_hash.h | 3 -- 2 files changed, 52 insertions(+), 17 deletions(-) diff --git a/lib/librte_hash/rte_fbk_hash.c b/lib/librte_hash/rte_fbk_hash.c index 4d67554..e566f48 100644 --- a/lib/librt

[dpdk-dev] [PATCH 3/7] rte_hash: make rte_hash tailq fully local

2014-06-13 Thread Anatoly Burakov
--- lib/librte_hash/rte_hash.c | 54 ++ lib/librte_hash/rte_hash.h | 2 -- 2 files changed, 45 insertions(+), 11 deletions(-) diff --git a/lib/librte_hash/rte_hash.c b/lib/librte_hash/rte_hash.c index d4221a8..a89ea44 100644 --- a/lib/librte_hash/rte_h

[dpdk-dev] [PATCH 1/7] rte_tailq: change rte_dummy to rte_tailq_entry, add data pointer

2014-06-13 Thread Anatoly Burakov
--- app/test/test_tailq.c | 33 --- lib/librte_eal/common/eal_common_tailqs.c | 2 +- lib/librte_eal/common/include/rte_tailq.h | 9 + 3 files changed, 23 insertions(+), 21 deletions(-) diff --git a/app/test/test_tailq.c b/app/test/test_ta

[dpdk-dev] [PATCH 6/7] rte_lpm: make lpm tailq fully local

2014-06-13 Thread Anatoly Burakov
--- lib/librte_lpm/rte_lpm.c | 54 lib/librte_lpm/rte_lpm.h | 2 -- 2 files changed, 45 insertions(+), 11 deletions(-) diff --git a/lib/librte_lpm/rte_lpm.c b/lib/librte_lpm/rte_lpm.c index 592750e..18a0cc0 100644 --- a/lib/librte_lpm/rte_lpm.c ++

[dpdk-dev] [PATCH v3 2/5] Link Bonding PMD Library (librte_eal/librte_ether link bonding support changes)

2014-06-13 Thread Neil Horman
On Fri, Jun 13, 2014 at 03:41:59PM +0100, Declan Doherty wrote: > Updating functionality in EAL to support adding link bonding > devices via ?vdev option. Link bonding devices will be > initialized after all physical devices have been probed and > initialized. > > Signed-off-by: Declan Doherty >

[dpdk-dev] Writing a new driver

2014-06-13 Thread Joubert Berger
I am looking at writing a new driver for DPDK for a NIC that is currently not supported. What is the best way to start this? Is the a porting guide? Or should I look at existing drivers as examples? --joubert

[dpdk-dev] [PATCH v2 00/10] igb_uio patches

2014-06-13 Thread Thomas Monjalon
Alan, Stephen, 2014-06-06 16:50, Stephen Hemminger: > These apply to the current DPDK tree, and are an alternative to > the patches from Alan. It provides indication of IRQ mode via > sysfs attribute. I need clear conclusion to these patch series. Alan, do you acknowledge Stephen's serie? If yes,

[dpdk-dev] [PATCH v2 0/4] NIC filters support for generic filter

2014-06-13 Thread Vladimir Medvedkin
Hi Jingjing, Yes, I agree. I have one more remark. It is about type of rx_queue arg. Now it is uint8_t. I think we have to change it to uint16_t because for Fortville NIC it is not enough. Quote fro the datasheet: A PF VSI (Virtual Station Interfaces aka virtual NICs) can allocate and use up to 15

[dpdk-dev] l2fwd application - packets not getting forwarded

2014-06-13 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Raj Ravi > Sent: Thursday, June 12, 2014 6:35 PM > To: dev at dpdk.org > Subject: Re: [dpdk-dev] l2fwd application - packets not getting forwarded > > Is there any requirement to modify l2fwd appliucation with u

[dpdk-dev] [PATCH] Add an API to query enabled core index

2014-06-13 Thread Patrick Lu
On Thu, Jun 12, 2014 at 08:54:11AM -0700, Richardson, Bruce wrote: > > > > -Original Message- > > From: Olivier MATZ [mailto:olivier.matz at 6wind.com] > > Sent: Thursday, June 12, 2014 1:20 AM > > To: Richardson, Bruce; Thomas Monjalon; Lu, Patrick > > Cc: dev at dpdk.org > > Subject: Re

[dpdk-dev] [PATCH v2 00/10] igb_uio patches

2014-06-13 Thread Stephen Hemminger
On Fri, 13 Jun 2014 18:14:28 +0200 Thomas Monjalon wrote: > Alan, Stephen, > > 2014-06-06 16:50, Stephen Hemminger: > > These apply to the current DPDK tree, and are an alternative to > > the patches from Alan. It provides indication of IRQ mode via > > sysfs attribute. > > I need clear conclus

[dpdk-dev] [PATCH] Add an API to query enabled core index

2014-06-13 Thread Richardson, Bruce
> -Original Message- > From: Lu, Patrick > Sent: Friday, June 13, 2014 9:58 AM > To: Richardson, Bruce > Cc: Olivier MATZ; Thomas Monjalon; dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH] Add an API to query enabled core index > > On Thu, Jun 12, 2014 at 08:54:11AM -0700, Richardson, B

[dpdk-dev] [PATCH] igb_uio: cap max VFs at 7 to reserve one for PF

2014-06-13 Thread Chris Wright
To keep from confusing users, cap max VFs at 7, despite PCI SR-IOV config space showing a max of 8. This reserves a queue pair for the PF. This issue was cited here: http://dpdk.org/ml/archives/dev/2014-April/001832.html Cc: Bruce Richardson Cc: Stephen Hemminger Signed-off-by: Chris Wright

[dpdk-dev] [PATCH] igb_uio: cap max VFs at 7 to reserve one for PF

2014-06-13 Thread Richardson, Bruce
> -Original Message- > From: Chris Wright [mailto:chrisw at redhat.com] > Sent: Friday, June 13, 2014 10:52 AM > To: Richardson, Bruce; Stephen Hemminger > Cc: Thomas Monjalon; dev at dpdk.org > Subject: [PATCH] igb_uio: cap max VFs at 7 to reserve one for PF > > To keep from confusing u

[dpdk-dev] [PATCH] igb_uio: cap max VFs at 7 to reserve one for PF

2014-06-13 Thread Chris Wright
* Richardson, Bruce (bruce.richardson at intel.com) wrote: > > > > -Original Message- > > From: Chris Wright [mailto:chrisw at redhat.com] > > Sent: Friday, June 13, 2014 10:52 AM > > To: Richardson, Bruce; Stephen Hemminger > > Cc: Thomas Monjalon; dev at dpdk.org > > Subject: [PATCH] ig

[dpdk-dev] [PATCH v3 2/5] Link Bonding PMD Library (librte_eal/librte_ether link bonding support changes)

2014-06-13 Thread Doherty, Declan
> -Original Message- > From: Neil Horman [mailto:nhorman at tuxdriver.com] > Sent: Friday, June 13, 2014 5:08 PM > To: Doherty, Declan > Cc: dev at dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/5] Link Bonding PMD Library > (librte_eal/librte_ether link bonding support changes) > > On Fri

[dpdk-dev] [PATCH] igb_uio: cap max VFs at 7 to reserve one for PF

2014-06-13 Thread Richardson, Bruce
> -Original Message- > From: Chris Wright [mailto:chrisw at redhat.com] > Sent: Friday, June 13, 2014 11:14 AM > To: Richardson, Bruce > Cc: Chris Wright; Stephen Hemminger; Thomas Monjalon; dev at dpdk.org > Subject: Re: [PATCH] igb_uio: cap max VFs at 7 to reserve one for PF > > * Richar

[dpdk-dev] [PATCH v3 2/5] Link Bonding PMD Library (librte_eal/librte_ether link bonding support changes)

2014-06-13 Thread Neil Horman
On Fri, Jun 13, 2014 at 06:34:04PM +, Doherty, Declan wrote: > > -Original Message- > > From: Neil Horman [mailto:nhorman at tuxdriver.com] > > Sent: Friday, June 13, 2014 5:08 PM > > To: Doherty, Declan > > Cc: dev at dpdk.org > > Subject: Re: [dpdk-dev] [PATCH v3 2/5] Link Bonding PMD

[dpdk-dev] [PATCH] igb_uio: cap max VFs at 7 to reserve one for PF

2014-06-13 Thread Chris Wright
* Richardson, Bruce (bruce.richardson at intel.com) wrote: > > -Original Message- > > From: Chris Wright [mailto:chrisw at redhat.com] > > Sent: Friday, June 13, 2014 11:14 AM > > To: Richardson, Bruce > > Cc: Chris Wright; Stephen Hemminger; Thomas Monjalon; dev at dpdk.org > > Subject: Re

[dpdk-dev] mmap() hint address

2014-06-13 Thread Gooch, Stephen
Hello, I have seen a case where a secondary DPDK process tries to map uio resource in which mmap() normally sends the corresponding virtual address as a hint address. However on some instances mmap() returns a virtual address that is not the hint address, and it result in rte_panic() and the s

[dpdk-dev] mmap() hint address

2014-06-13 Thread Richardson, Bruce
> -Original Message- > From: dev [mailto:dev-bounces at dpdk.org] On Behalf Of Gooch, Stephen > Sent: Friday, June 13, 2014 2:03 PM > To: dev at dpdk.org > Subject: [dpdk-dev] mmap() hint address > > Hello, > > I have seen a case where a secondary DPDK process tries to map uio resource in

[dpdk-dev] [PATCH v3 2/5] Link Bonding PMD Library (librte_eal/librte_ether link bonding support changes)

2014-06-13 Thread Stephen Hemminger
On Fri, 13 Jun 2014 15:41:59 +0100 Declan Doherty wrote: > Updating functionality in EAL to support adding link bonding > devices via ???vdev option. Link bonding devices will be > initialized after all physical devices have been probed and > initialized. > > Signed-off-by: Declan Doherty The

[dpdk-dev] [PATCH v3] 10G PMD: New vectorized functions for RX/TX

2014-06-13 Thread Bruce Richardson
From: "Richardson, Bruce" New file containing optimized receive and transmit functions which use 128bit vector instructions to improve performance. When conditions permit, these functions will be enabled at runtime by the device initialization routines already in the PMD. The compilation of the

[dpdk-dev] [PATCH 0/8] virtio driver phase 2

2014-06-13 Thread Stephen Hemminger
This is second group of patches for cleaning up virtio driver prior to the functionality changes in next phase.

[dpdk-dev] [PATCH 1/8] virtio: maintain stats per queue

2014-06-13 Thread Stephen Hemminger
Avoid cache collision and thrashing of the software statistics by keeping them per-queue in the driver. Signed-off-by: Stephen Hemminger --- a/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-13 17:41:11.634778400 -0700 +++ b/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-13 17:48:08.235480

[dpdk-dev] [PATCH 2/8] virtio: dont double space log messages

2014-06-13 Thread Stephen Hemminger
PMD_INIT_LOG macro already adds a newline, no need to double space. --- lib/librte_pmd_virtio/virtio_ethdev.c | 98 +- lib/librte_pmd_virtio/virtio_rxtx.c | 28 - lib/librte_pmd_virtio/virtqueue.h |4 - 3 files changed, 66 insertions(+), 64 de

[dpdk-dev] [PATCH 3/8] virtio: deinline some code

2014-06-13 Thread Stephen Hemminger
This driver has lots of functions marked always inline which is actually counterproductive with modern compilers. Better to move the functions to the one file they are used (proper scope) and let compiler decide. For trivial functions leave them as static inline. Signed-off-by: Stephen Hemminger

[dpdk-dev] [PATCH 4/8] virtio: check for transmit checksum config error

2014-06-13 Thread Stephen Hemminger
This driver does not support transmit checksum or vlan offload therefore check for this when device is configured. Signed-off-by: Stephen Hemminger --- lib/librte_ether/rte_ethdev.h |8 +--- lib/librte_pmd_virtio/virtio_rxtx.c |9 - 2 files changed, 13 insertions(+), 4

[dpdk-dev] [PATCH 5/8] virtio: check for ip checksum offload

2014-06-13 Thread Stephen Hemminger
This driver does not support receive IP checksum offload, therefore must check and return error if configured incorrectly. Signed-off-by: Stephen Hemminger --- a/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-13 17:55:19.928278206 -0700 +++ b/lib/librte_pmd_virtio/virtio_ethdev.c 2014-0

[dpdk-dev] [PATCH 6/8] virtio: remove unused virtqueue name

2014-06-13 Thread Stephen Hemminger
vq_name is only used when setting up queue, and does not need to be saved. Signed-off-by: Stephen Hemminger --- a/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-13 18:00:41.944914744 -0700 +++ b/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-13 18:00:41.936914729 -0700 @@ -271,20 +271,1

[dpdk-dev] [PATCH 7/8] virtio: remove unused adapter_stopped field

2014-06-13 Thread Stephen Hemminger
This flag was set to zero (but was already zero) and never used. Signed-off-by: Stephen Hemminger --- a/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-13 18:01:14.152978473 -0700 +++ b/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-13 18:01:14.144978461 -0700 @@ -927,8 +927,6 @@ virtio_d

[dpdk-dev] [PATCH 8/8] virtio: simplify the hardware structure

2014-06-13 Thread Stephen Hemminger
The host_features are never used after negotiation. The PCI information is unused (and available in rte_pci if needed). Signed-off-by: Stephen Hemminger --- a/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-13 18:01:46.905019605 -0700 +++ b/lib/librte_pmd_virtio/virtio_ethdev.c 2014-06-1