Re: vmxnet3 no longer functional on DPDK 21.11

2024-01-11 Thread Lewis Donzis
- On Jan 9, 2024, at 5:55 PM, Stephen Hemminger step...@networkplumber.org wrote: > Probably need to go further with this. > - what about unreigster in vmxnet3_dev_stop > - vmxnet3_interrupt_handler is then dead code, should it be #ifdef guarded? > - and vmxnet3_dev_rx_queue_intr_enable/dis

Re: vmxnet3 no longer functional on DPDK 21.11

2024-01-10 Thread Lewis Donzis
- On Jan 9, 2024, at 8:28 AM, Bruce Richardson bruce.richard...@intel.com wrote: > On Tue, Jan 09, 2024 at 07:46:47AM -0600, Lewis Donzis wrote: >> Hi, Bruce. >> >> I'm even less familiar with it, but we do quite a lot of testing using VMs, >> so >> it's been quite handy. >> >> Your pat

Re: vmxnet3 no longer functional on DPDK 21.11

2024-01-10 Thread Lewis Donzis
Hi, Bruce. I'm even less familiar with it, but we do quite a lot of testing using VMs, so it's been quite handy. Your patch seems very reasonable, however it also produces a warning: ../drivers/net/vmxnet3/vmxnet3_ethdev.c:264:1: warning: unused function 'vmxnet3_enable_all_intrs' [-Wunused-fu

Re: vmxnet3 no longer functional on DPDK 21.11

2024-01-09 Thread Bruce Richardson
On Tue, Jan 09, 2024 at 09:21:47AM -0600, Lewis Donzis wrote: > > > - On Jan 9, 2024, at 8:28 AM, Bruce Richardson bruce.richard...@intel.com > wrote: > > > On Tue, Jan 09, 2024 at 07:46:47AM -0600, Lewis Donzis wrote: > >> Hi, Bruce. > >> > >> I'm even less familiar with it, but we do qui

Re: vmxnet3 no longer functional on DPDK 21.11

2024-01-09 Thread Bruce Richardson
On Tue, Jan 09, 2024 at 07:46:47AM -0600, Lewis Donzis wrote: > Hi, Bruce. > > I'm even less familiar with it, but we do quite a lot of testing using VMs, > so it's been quite handy. > > Your patch seems very reasonable, however it also produces a warning: > > ../drivers/net/vmxnet3/vmxnet3_eth

Re: vmxnet3 no longer functional on DPDK 21.11

2024-01-09 Thread Bruce Richardson
On Sat, Jan 06, 2024 at 08:50:03AM -0600, Lewis Donzis wrote: > Good morning. > > I just wanted to mention that this problem still persists in 22.11.3, and we > still have to patch the vmxnet3 driver every time we upgrade. > > As mentioned before, ixgbe_ethdev.c is an example of a driver that if

Re: vmxnet3 no longer functional on DPDK 21.11

2024-01-08 Thread Lewis Donzis
6, 2021 9:17 AM >>> To: Lewis Donzis >>> Cc: dev ; Wang, Yong ; Ananyev, >>> Konstantin >>> >>> Subject: Re: vmxnet3 no longer functional on DPDK 21.11 >>> >>> On Sun, Dec 05, 2021 at 07:52:33PM -0600, Lewis Donzis wrote: >>&

Re: vmxnet3 no longer functional on DPDK 21.11

2022-06-03 Thread Ferruh Yigit
ed new maintainer, Jochen. - On Dec 6, 2021, at 6:08 AM, Konstantin Ananyev konstantin.anan...@intel.com wrote: -Original Message- From: Richardson, Bruce Sent: Monday, December 6, 2021 9:17 AM To: Lewis Donzis Cc: dev ; Wang, Yong ; Ananyev, Konstantin Subject: Re: vmxnet3 no longer fun

Re: vmxnet3 no longer functional on DPDK 21.11

2022-06-03 Thread Lewis Donzis
yev konstantin.anan...@intel.com wrote: >> -Original Message- >> From: Richardson, Bruce >> Sent: Monday, December 6, 2021 9:17 AM >> To: Lewis Donzis >> Cc: dev ; Wang, Yong ; Ananyev, Konstantin >> >> Subject: Re: vmxnet3 no longer functional on DPD

Re: vmxnet3 no longer functional on DPDK 21.11

2021-12-06 Thread Lewis Donzis
- On Dec 6, 2021, at 6:08 AM, Ananyev, Konstantin konstantin.anan...@intel.com wrote: > So to clarify, it fails at: > static int > vmxnet3_dev_start(struct rte_eth_dev *dev) > { > ... > line 1695: > if (rte_intr_enable(dev->intr_handle) < 0) { >PMD_INIT_LOG(ERR,

RE: vmxnet3 no longer functional on DPDK 21.11

2021-12-06 Thread Ananyev, Konstantin
> -Original Message- > From: Richardson, Bruce > Sent: Monday, December 6, 2021 9:17 AM > To: Lewis Donzis > Cc: dev ; Wang, Yong ; Ananyev, Konstantin > > Subject: Re: vmxnet3 no longer functional on DPDK 21.11 > > On Sun, Dec 05, 2021 at 07:52:33P

Re: vmxnet3 no longer functional on DPDK 21.11

2021-12-06 Thread Bruce Richardson
On Sun, Dec 05, 2021 at 07:52:33PM -0600, Lewis Donzis wrote: > > > - On Nov 30, 2021, at 7:42 AM, Bruce Richardson > bruce.richard...@intel.com wrote: > > > On Mon, Nov 29, 2021 at 02:45:15PM -0600, Lewis Donzis wrote: > >>Hello. > >>We just upgraded from 21.08 to 21.11 and it's ra

Re: vmxnet3 no longer functional on DPDK 21.11

2021-12-05 Thread Lewis Donzis
- On Nov 30, 2021, at 7:42 AM, Bruce Richardson bruce.richard...@intel.com wrote: > On Mon, Nov 29, 2021 at 02:45:15PM -0600, Lewis Donzis wrote: >>Hello. >>We just upgraded from 21.08 to 21.11 and it's rather astounding the >>number of incompatible changes in three months. No

Re: vmxnet3 no longer functional on DPDK 21.11

2021-11-30 Thread Bruce Richardson
On Mon, Nov 29, 2021 at 02:45:15PM -0600, Lewis Donzis wrote: >Hello. >We just upgraded from 21.08 to 21.11 and it's rather astounding the >number of incompatible changes in three months. Not a big deal, just >kind of a surprise, that's all. >Anyway, the problem is that the vmx

Re: vmxnet3 no longer functional on DPDK 21.11

2021-11-30 Thread Ferruh Yigit
On 11/29/2021 8:45 PM, Lewis Donzis wrote: Hello. We just upgraded from 21.08 to 21.11 and it's rather astounding the number of incompatible changes in three months.  Not a big deal, just kind of a surprise, that's all. Anyway, the problem is that the vmxnet3 driver is no longer functional on

vmxnet3 no longer functional on DPDK 21.11

2021-11-29 Thread Lewis Donzis
Hello. We just upgraded from 21.08 to 21.11 and it's rather astounding the number of incompatible changes in three months. Not a big deal, just kind of a surprise, that's all. Anyway, the problem is that the vmxnet3 driver is no longer functional on FreeBSD. In drivers/net/vmxnet3/vmxnet3_