Re: [PATCH] devargs: Fix rte_devargs_parse uninitialized calls

2022-02-16 Thread Gaëtan Rivet
On Tue, Feb 15, 2022, at 16:27, David Marchand wrote: > On Thu, Feb 10, 2022 at 6:01 PM Gaetan Rivet wrote: >> >> The function rte_devargs_parse() previously was safe to call with >> non-initialized devargs structure as parameter. >> >> When adding the sup

Re: [PATCH] devargs: Fix rte_devargs_parse uninitialized calls

2022-02-15 Thread David Marchand
On Thu, Feb 10, 2022 at 6:01 PM Gaetan Rivet wrote: > > The function rte_devargs_parse() previously was safe to call with > non-initialized devargs structure as parameter. > > When adding the support for the global device syntax, > this assumption was broken. Restore it by forc

Re: [PATCH] devargs: Fix rte_devargs_parse uninitialized calls

2022-02-15 Thread Gaëtan Rivet
On Tue, Feb 15, 2022, at 13:51, Ferruh Yigit wrote: > On 2/10/2022 5:01 PM, Gaetan Rivet wrote: >> The function rte_devargs_parse() previously was safe to call with >> non-initialized devargs structure as parameter. >> >> When adding the support for the global device

Re: [PATCH] devargs: Fix rte_devargs_parse uninitialized calls

2022-02-15 Thread Ferruh Yigit
On 2/10/2022 5:01 PM, Gaetan Rivet wrote: The function rte_devargs_parse() previously was safe to call with non-initialized devargs structure as parameter. When adding the support for the global device syntax, this assumption was broken. Restore it by forcing memset as part of the call itself

[PATCH] devargs: Fix rte_devargs_parse uninitialized calls

2022-02-10 Thread Gaetan Rivet
The function rte_devargs_parse() previously was safe to call with non-initialized devargs structure as parameter. When adding the support for the global device syntax, this assumption was broken. Restore it by forcing memset as part of the call itself. Bugzilla Id: 933 Fixes: b344eb5d941a

rte_devargs_parse

2022-02-02 Thread Dmitry Kozlyuk
. * * [SNIP] */ int rte_devargs_parse(struct rte_devargs *da, const char *dev); It is unclear from this description that "da" is not only filled, but also used as an input, and if it is not initialized or at least zero-filled, the function will crash. "Holding the device information&