Re:Re: [PATCH v7] ip_frag: add IPv4 options fragment and test data

2022-06-18 Thread Huichao Cai
Hi,Stephen Thank you very much for your reply! >I would just replace all of the rte_memcpy with memcpy I will replace all of the rte_memcpy with memcpy. >I expect that rte_memcpy() is able to do better than memcpy() for larger >copies because it is >likely to use bigger vector instructions and c

Re:Re: [PATCH v7] ip_frag: add IPv4 options fragment and test data

2022-06-16 Thread Huichao Cai
Hi,Stephen There are some things I don't quite understand.Hope you can answer that. This will help me avoid similar errors in subsequent patch submissions.Thanks! There are places where rte_memcpy functions are used: In test_ipfrag.c: from func test_

Re:RE: [PATCH v7] ip_frag: add IPv4 options fragment and test data

2022-05-29 Thread Huichao Cai
Hi Konstantin, This patch has been around for a long time, so what's next? Huichao,Cai At 2022-04-15 16:29:10, "Ananyev, Konstantin" wrote: >> According to RFC791,the options may appear or not in datagrams. >> They must be implemented by all IP modules (host and gateways). >> What is optional is

Re:RE: [PATCH v7] ip_frag: add IPv4 options fragment and test data

2022-05-29 Thread Huichao Cai
Hi Konstantin, This patch has been around for a long time, so what's next? Huichao,Cai At 2022-04-15 16:29:10, "Ananyev, Konstantin" wrote: >> According to RFC791,the options may appear or not in datagrams. >> They must be implemented by all IP modules (host and gateways). >> What is optional is