Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-31 Thread Bruce Richardson
On Tue, Jan 31, 2017 at 02:27:18PM +0100, Olivier Matz wrote: > On Tue, 31 Jan 2017 12:10:50 +, Bruce Richardson > wrote: > > On Tue, Jan 31, 2017 at 11:41:42AM +, Bruce Richardson wrote: > > > On Tue, Jan 31, 2017 at 11:53:49AM +0100, Olivier Matz wrote: > > > > On Wed, 25 Jan 2017 17:2

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-31 Thread Olivier Matz
On Tue, 31 Jan 2017 12:10:50 +, Bruce Richardson wrote: > On Tue, Jan 31, 2017 at 11:41:42AM +, Bruce Richardson wrote: > > On Tue, Jan 31, 2017 at 11:53:49AM +0100, Olivier Matz wrote: > > > On Wed, 25 Jan 2017 17:29:18 +, "Ananyev, Konstantin" > > > wrote: > > > > > > > Bonus qu

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-31 Thread Bruce Richardson
On Tue, Jan 31, 2017 at 11:41:42AM +, Bruce Richardson wrote: > On Tue, Jan 31, 2017 at 11:53:49AM +0100, Olivier Matz wrote: > > On Wed, 25 Jan 2017 17:29:18 +, "Ananyev, Konstantin" > > wrote: > > > > > > Bonus question: > > > > > > * Do we know how widely used the enq_bulk/deq_bulk func

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-31 Thread Bruce Richardson
On Tue, Jan 31, 2017 at 11:53:49AM +0100, Olivier Matz wrote: > On Wed, 25 Jan 2017 17:29:18 +, "Ananyev, Konstantin" > wrote: > > > > > Bonus question: > > > > > * Do we know how widely used the enq_bulk/deq_bulk functions > > > > > are? They are useful for unit tests, so they do have uses, b

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-31 Thread Olivier Matz
On Wed, 25 Jan 2017 17:29:18 +, "Ananyev, Konstantin" wrote: > > > > Bonus question: > > > > * Do we know how widely used the enq_bulk/deq_bulk functions > > > > are? They are useful for unit tests, so they do have uses, but > > > > I think it would be good if we harmonized the return values >

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-25 Thread Wiles, Keith
> On Jan 25, 2017, at 9:57 AM, Richardson, Bruce > wrote: > > On Wed, Jan 25, 2017 at 03:59:55PM +, Wiles, Keith wrote: >> >> >> Sent from my iPhone >> >>> On Jan 25, 2017, at 7:48 AM, Bruce Richardson >>> wrote: >>> On Wed, Jan 25, 2017 at 01:54:04PM +, Bruce Richardson wrot

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-25 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Bruce Richardson > Sent: Wednesday, January 25, 2017 4:58 PM > To: Wiles, Keith > Cc: Olivier MATZ ; dev@dpdk.org > Subject: Re: [dpdk-dev] rte_ring features in use (or not) > > On We

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-25 Thread Bruce Richardson
On Wed, Jan 25, 2017 at 03:59:55PM +, Wiles, Keith wrote: > > > Sent from my iPhone > > > On Jan 25, 2017, at 7:48 AM, Bruce Richardson > > wrote: > > > >> On Wed, Jan 25, 2017 at 01:54:04PM +, Bruce Richardson wrote: > >>> On Wed, Jan 25, 2017 at 02:20:52PM +0100, Olivier MATZ wrote:

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-25 Thread Stephen Hemminger
On Wed, 25 Jan 2017 14:20:52 +0100 Olivier MATZ wrote: > > * Who uses the watermarks feature as is? I know we have a sample app > > that uses it, but there are better ways I think to achieve the same > > goal while simplifying the ring implementation. Rather than have a > > set watermark on e

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-25 Thread Wiles, Keith
Sent from my iPhone > On Jan 25, 2017, at 7:48 AM, Bruce Richardson > wrote: > >> On Wed, Jan 25, 2017 at 01:54:04PM +, Bruce Richardson wrote: >>> On Wed, Jan 25, 2017 at 02:20:52PM +0100, Olivier MATZ wrote: >>> On Wed, 25 Jan 2017 12:14:56 +, Bruce Richardson >>> wrote: Hi al

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-25 Thread Bruce Richardson
On Wed, Jan 25, 2017 at 01:54:04PM +, Bruce Richardson wrote: > On Wed, Jan 25, 2017 at 02:20:52PM +0100, Olivier MATZ wrote: > > On Wed, 25 Jan 2017 12:14:56 +, Bruce Richardson > > wrote: > > > Hi all, > > > > > > while looking at the rte_ring code, I'm wondering if we can simplify > >

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-25 Thread Bruce Richardson
On Wed, Jan 25, 2017 at 02:20:52PM +0100, Olivier MATZ wrote: > On Wed, 25 Jan 2017 12:14:56 +, Bruce Richardson > wrote: > > Hi all, > > > > while looking at the rte_ring code, I'm wondering if we can simplify > > that a bit by removing some of the code it in that may not be used. > > Specif

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-25 Thread Olivier MATZ
On Wed, 25 Jan 2017 12:14:56 +, Bruce Richardson wrote: > Hi all, > > while looking at the rte_ring code, I'm wondering if we can simplify > that a bit by removing some of the code it in that may not be used. > Specifically: > > * Does anyone use the NIC stats functionality for debugging? I'

Re: [dpdk-dev] rte_ring features in use (or not)

2017-01-25 Thread Bruce Richardson
On Wed, Jan 25, 2017 at 12:14:56PM +, Bruce Richardson wrote: > Hi all, > > while looking at the rte_ring code, I'm wondering if we can simplify > that a bit by removing some of the code it in that may not be used. > Specifically: > > * Does anyone use the NIC stats functionality for debuggin