Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-10-21 Thread Thomas Monjalon
30/09/2021 15:29, Ali Alnubani: > From: Olivier Matz > > On Wed, Sep 29, 2021 at 08:03:17AM +, Ali Alnubani wrote: > > > Hi Olivier, > > > > > > I wanted to retest the patch on latest main, but it no longer applies, > > > could > > you please rebase it? > > > > I rebased the patch: > > https

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-09-30 Thread Ali Alnubani
Morten > Brørup ; Andrew Rybchenko > ; Ananyev, Konstantin > ; Ajit Khaparde > ; jer...@marvell.com > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf > free > > Hi Ali, > > > On Wed, Sep 29, 2021 at 08:03:17AM +, Ali Alnubani wrote: >

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-09-29 Thread Olivier Matz
i Alnubani > > Cc: dev@dpdk.org; David Marchand ; Alexander > > Kozyrev ; Ferruh Yigit ; > > zhaoyan.c...@intel.com; Andrew Rybchenko > > ; Ananyev, Konstantin > > ; Ajit Khaparde > > ; jer...@marvell.com > > Subject: RE: [dpdk-dev] [dpdk-stable] [PATCH v4] m

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-09-29 Thread Ali Alnubani
; Olivier Matz ; > Ali Alnubani > Cc: dev@dpdk.org; David Marchand ; Alexander > Kozyrev ; Ferruh Yigit ; > zhaoyan.c...@intel.com; Andrew Rybchenko > ; Ananyev, Konstantin > ; Ajit Khaparde > ; jer...@marvell.com > Subject: RE: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf:

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-09-28 Thread Slava Ovsiienko
ruh Yigit ; > zhaoyan.c...@intel.com; Andrew Rybchenko > ; Ananyev, Konstantin > ; Ajit Khaparde > ; jer...@marvell.com > Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf > free > > Follow-up again: > We have added a note in 21.08, we should fix it i

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-09-28 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Slava Ovsiienko > Sent: Tuesday, 28 September 2021 11.01 > > Hi, > > I've re-read the entire thread. > If I understand correctly, the root problem was (in initial patch): > > > m1 = rte_pktmbuf_alloc(mp); > > rte_pktmbuf_append(m1, 500);

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-09-28 Thread Ananyev, Konstantin
> To: Olivier Matz ; Ali Alnubani > > ; Slava Ovsiienko > > Cc: Morten Brørup ; dev@dpdk.org; David > > Marchand ; Alexander Kozyrev > > ; Ferruh Yigit ; > > zhaoyan.c...@intel.com; Andrew Rybchenko > > ; Ananyev, Konstantin > > ; Ajit Khaparde >

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-09-28 Thread Thomas Monjalon
Follow-up again: We have added a note in 21.08, we should fix it in 21.11. If there are no counter proposal, I suggest applying this patch, no matter the performance regression. 30/07/2021 16:54, Thomas Monjalon: > 30/07/2021 16:35, Morten Brørup: > > > From: Olivier Matz [mailto:olivier.m...@6wi

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-30 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Friday, 30 July 2021 17.15 > > Hi, > > On Fri, Jul 30, 2021 at 04:54:05PM +0200, Thomas Monjalon wrote: > > 30/07/2021 16:35, Morten Brørup: > > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > > Sent: Friday,

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-30 Thread Olivier Matz
Hi, On Fri, Jul 30, 2021 at 04:54:05PM +0200, Thomas Monjalon wrote: > 30/07/2021 16:35, Morten Brørup: > > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > > Sent: Friday, 30 July 2021 14.37 > > > > > > Hi Thomas, > > > > > > On Sat, Jul 24, 2021 at 10:47:34AM +0200, Thomas Monjalon wro

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-30 Thread Thomas Monjalon
30/07/2021 16:35, Morten Brørup: > > From: Olivier Matz [mailto:olivier.m...@6wind.com] > > Sent: Friday, 30 July 2021 14.37 > > > > Hi Thomas, > > > > On Sat, Jul 24, 2021 at 10:47:34AM +0200, Thomas Monjalon wrote: > > > What's the follow-up for this patch? > > > > Unfortunatly, I still don't

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-30 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Friday, 30 July 2021 14.37 > > Hi Thomas, > > On Sat, Jul 24, 2021 at 10:47:34AM +0200, Thomas Monjalon wrote: > > What's the follow-up for this patch? > > Unfortunatly, I still don't have the time to work on this topic yet. > > In my

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-30 Thread Olivier Matz
Hi Thomas, On Sat, Jul 24, 2021 at 10:47:34AM +0200, Thomas Monjalon wrote: > What's the follow-up for this patch? Unfortunatly, I still don't have the time to work on this topic yet. In my initial tests, in our lab, I didn't notice any performance regression, but Ali has seen an impact (0.5M PP

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-07-24 Thread Thomas Monjalon
What's the follow-up for this patch? 19/01/2021 15:04, Slava Ovsiienko: > Hi, All > > Could we postpose this patch at least to rc2? We would like to conduct more > investigations? > > With best regards, Slava > > From: Olivier Matz > > On Mon, Jan 18, 2021 at 05:52:32PM +, Ali Alnubani wr

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-21 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Thursday, January 21, 2021 10:19 AM > > On 1/15/2021 6:39 PM, Ali Alnubani wrote: > > Hi, > > Adding Ferruh and Zhaoyan, > > > >> Ali, > >> > >> You reported some performance regression, did you confirm it? > >> If I get n

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-21 Thread Ferruh Yigit
On 1/15/2021 6:39 PM, Ali Alnubani wrote: Hi, Adding Ferruh and Zhaoyan, Ali, You reported some performance regression, did you confirm it? If I get no reply by monday, I'll proceed with this patch. Sure I'll confirm by Monday. Doesn't the regression also reproduce on the Lab's Intel server

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-21 Thread Ferruh Yigit
On 1/19/2021 2:21 PM, Morten Brørup wrote: From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] Sent: Tuesday, January 19, 2021 3:03 PM On 1/19/2021 12:27 PM, Morten Brørup wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit Sent: Tuesday, January 19, 2021 1:01 PM On 1/19/20

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-19 Thread Morten Brørup
> From: Ferruh Yigit [mailto:ferruh.yi...@intel.com] > Sent: Tuesday, January 19, 2021 3:03 PM > > On 1/19/2021 12:27 PM, Morten Brørup wrote: > >> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > >> Sent: Tuesday, January 19, 2021 1:01 PM > >> > >> On 1/19/2021 8:53 AM, Morten

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-19 Thread Ferruh Yigit
On 1/19/2021 12:27 PM, Morten Brørup wrote: From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit Sent: Tuesday, January 19, 2021 1:01 PM On 1/19/2021 8:53 AM, Morten Brørup wrote: Could someone at Intel please update the test script to provide output according to the test plan? Or

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-19 Thread Slava Ovsiienko
Hi, All Could we postpose this patch at least to rc2? We would like to conduct more investigations? With best regards, Slava > -Original Message- > From: Olivier Matz > Sent: Tuesday, January 19, 2021 10:32 > To: Ali Alnubani > Cc: David Marchand ; Ferruh Yigit > ; zhaoyan.c...@intel.

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-19 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Ferruh Yigit > Sent: Tuesday, January 19, 2021 1:01 PM > > On 1/19/2021 8:53 AM, Morten Brørup wrote: > > Could someone at Intel please update the test script to provide > output according to the test plan? Or delegate to the right person. > >

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-19 Thread Ferruh Yigit
On 1/19/2021 8:53 AM, Morten Brørup wrote: Could someone at Intel please update the test script to provide output according to the test plan? Or delegate to the right person. According to the test plan, the information requested by Olivier should be in the test output already: http://git.dpdk.

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-19 Thread Morten Brørup
Could someone at Intel please update the test script to provide output according to the test plan? Or delegate to the right person. According to the test plan, the information requested by Olivier should be in the test output already: http://git.dpdk.org/tools/dts/tree/test_plans/nic_single_core

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-19 Thread Olivier Matz
Hi Ali, On Mon, Jan 18, 2021 at 05:52:32PM +, Ali Alnubani wrote: > Hi, > (Sorry had to resend this to some recipients due to mail server problems). > > Just confirming that I can still reproduce the regression with single core > and 64B frames on other servers. Many thanks for the feedbac

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-18 Thread Ali Alnubani
Hi, (Sorry had to resend this to some recipients due to mail server problems). Just confirming that I can still reproduce the regression with single core and 64B frames on other servers. - Ali > -Original Message- > From: Ali Alnubani > Sent: Friday, January 15, 2021 8:39 PM > To: Davi

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-15 Thread Ali Alnubani
Hi, Adding Ferruh and Zhaoyan, > Ali, > > You reported some performance regression, did you confirm it? > If I get no reply by monday, I'll proceed with this patch. Sure I'll confirm by Monday. Doesn't the regression also reproduce on the Lab's Intel servers? Even though the check iol-intel-Per

Re: [dpdk-dev] [dpdk-stable] [PATCH v4] mbuf: fix reset on mbuf free

2021-01-15 Thread David Marchand
On Wed, Jan 13, 2021 at 2:28 PM Olivier Matz wrote: > > m->nb_seg must be reset on mbuf free whatever the value of m->next, > because it can happen that m->nb_seg is != 1. For instance in this > case: > > m1 = rte_pktmbuf_alloc(mp); > rte_pktmbuf_append(m1, 500); > m2 = rte_pktmbuf_alloc(mp)