Hi Fan,
> Hi Akhil,
>
> Konstantin and I had an off-line discussion. Is this structure ok for you?
>
> /**
> * Crypto virtual and IOVA address descriptor. Used to describe cryptographic
> * data without
The comment is incomplete, however the structure is fine.
> *
> */
> struct rte_crypto_v
Hi Akhil,
Konstantin and I had an off-line discussion. Is this structure ok for you?
/**
* Crypto virtual and IOVA address descriptor. Used to describe cryptographic
* data without
*
*/
struct rte_crypto_va_iova_ptr {
void *va;
rte_iova_t *iova;
};
/**
* Raw data operation d
Hi Konstantin,
> -Original Message-
> From: Ananyev, Konstantin
> Sent: Tuesday, September 22, 2020 11:18 AM
> To: Zhang, Roy Fan ; Akhil Goyal
> ; dev@dpdk.org; Thomas Monjalon
>
> Cc: Trahe, Fiona ; Kusztal, ArkadiuszX
> ; Dybkowski, AdamX
> ; Bronowski, PiotrX
> ; Anoob Joseph
> Subj
>
> Hi Akhil and Konstantin,
>
> > -Original Message-
> > From: Akhil Goyal
> > Sent: Tuesday, September 22, 2020 10:06 AM
> > To: Ananyev, Konstantin ; Zhang, Roy Fan
> > ; dev@dpdk.org; Thomas Monjalon
> >
> > Cc: Trahe, Fiona ; Kusztal, ArkadiuszX
> > ; Dybkowski, AdamX
> > ; Bron
Hi Akhil and Konstantin,
> -Original Message-
> From: Akhil Goyal
> Sent: Tuesday, September 22, 2020 10:06 AM
> To: Ananyev, Konstantin ; Zhang, Roy Fan
> ; dev@dpdk.org; Thomas Monjalon
>
> Cc: Trahe, Fiona ; Kusztal, ArkadiuszX
> ; Dybkowski, AdamX
> ; Bronowski, PiotrX
> ; Anoob Jose
Hi Konstantin,
> Hi lads,
>
> >
> > Hi Akhil,
> >
> > Thanks again for the review!
> > To summarize, the following places to be changed for v10.
> >
> > 1. Documentation update and reviewed internally in Intel first.
> > 2. Add the missing comments to the structure.
> > 3. Change the name "dp_serv
Hi lads,
>
> Hi Akhil,
>
> Thanks again for the review!
> To summarize, the following places to be changed for v10.
>
> 1. Documentation update and reviewed internally in Intel first.
> 2. Add the missing comments to the structure.
> 3. Change the name "dp_service" to "raw_dp" to all APIs and d
Hi Akhil,
Thanks again for the review!
To summarize, the following places to be changed for v10.
1. Documentation update and reviewed internally in Intel first.
2. Add the missing comments to the structure.
3. Change the name "dp_service" to "raw_dp" to all APIs and documentation.
4. Change the s
Hi Akhil,
> -Original Message-
> From: Akhil Goyal
> Sent: Monday, September 21, 2020 4:49 PM
> To: Zhang, Roy Fan ; dev@dpdk.org; Ananyev,
> Konstantin ; Thomas Monjalon
>
> Cc: Trahe, Fiona ; Kusztal, ArkadiuszX
> ; Dybkowski, AdamX
> ; Bronowski, PiotrX
> ; Anoob Joseph
> Subject: RE
Hi Fan,
> Hi AKhil
>
> ...
> > IMO, the following union can clarify all doubts.
> > @Ananyev, Konstantin: Any suggestions from your side?
> >
> > /** IV and aad information for various use cases. */
> > union {
> > /** Supposed to be used with CPU crypto API call. */
> > struct {
>
Hi AKhil
> -Original Message-
> From: Akhil Goyal
> Sent: Monday, September 21, 2020 1:00 PM
> To: Zhang, Roy Fan ; dev@dpdk.org; Ananyev,
> Konstantin ; Thomas Monjalon
>
> Cc: Trahe, Fiona ; Kusztal, ArkadiuszX
> ; Dybkowski, AdamX
> ; Bronowski, PiotrX
> ; Anoob Joseph
> Subject: RE:
Hi Akhil,
> -Original Message-
> From: Akhil Goyal
> Sent: Monday, September 21, 2020 1:00 PM
> To: Zhang, Roy Fan ; dev@dpdk.org; Ananyev,
> Konstantin ; Thomas Monjalon
>
> Cc: Trahe, Fiona ; Kusztal, ArkadiuszX
> ; Dybkowski, AdamX
> ; Bronowski, PiotrX
> ; Anoob Joseph
> Subject: RE
Hi Fan,
> > >
> > > +/** Crypto data-path service types */
> > > +enum rte_crypto_dp_service {
> > > + RTE_CRYPTO_DP_SYM_CIPHER_ONLY = 0,
> > > + RTE_CRYPTO_DP_SYM_AUTH_ONLY,
> > > + RTE_CRYPTO_DP_SYM_CHAIN,
> > > + RTE_CRYPTO_DP_SYM_AEAD,
> > > + RTE_CRYPTO_DP_N_SERVICE
> > > +};
> >
> > Comments
Hi Akhil,
Thanks for the review!
> -Original Message-
> From: Akhil Goyal
> Sent: Friday, September 18, 2020 10:50 PM
> To: Zhang, Roy Fan ; dev@dpdk.org
> Cc: Trahe, Fiona ; Kusztal, ArkadiuszX
> ; Dybkowski, AdamX
> ; Bronowski, PiotrX
> ; Anoob Joseph
> Subject: RE: [dpdk-dev v9 1/4]
Hi Fan,
> Subject: [dpdk-dev v9 1/4] cryptodev: add crypto data-path service APIs
>
> This patch adds data-path service APIs for enqueue and dequeue
> operations to cryptodev. The APIs support flexible user-define
> enqueue and dequeue behaviors and operation mode.
>
> Signed-off-by: Fan Zhang
15 matches
Mail list logo
