Re: [dpdk-dev] [RFC UPDATE PATCH 0/9] dmadev rfc suggested updates

2021-07-07 Thread Jerin Jacob
On Wed, Jul 7, 2021 at 8:46 AM fengchengwen wrote: > > LGTM, thanks > > And I'am prepare dmadev V2, include: > a) Fix code review comments (e.g. multiple-process support, doxygen, > comments, typo) > b) Flatten device abstraction to two layer: dmadev <> vchan I think we should not have "virtual"

Re: [dpdk-dev] [RFC UPDATE PATCH 0/9] dmadev rfc suggested updates

2021-07-07 Thread Bruce Richardson
On Wed, Jul 07, 2021 at 11:16:44AM +0800, fengchengwen wrote: > LGTM, thanks > > And I'am prepare dmadev V2, include: a) Fix code review comments (e.g. > multiple-process support, doxygen, comments, typo) b) Flatten device > abstraction to two layer: dmadev <> vchan c) Public API use dev_id and >

Re: [dpdk-dev] [RFC UPDATE PATCH 0/9] dmadev rfc suggested updates

2021-07-07 Thread Bruce Richardson
On Wed, Jul 07, 2021 at 11:16:44AM +0800, fengchengwen wrote: > LGTM, thanks > > And I'am prepare dmadev V2, include: > a) Fix code review comments (e.g. multiple-process support, doxygen, > comments, typo) > b) Flatten device abstraction to two layer: dmadev <> vchan > c) Public API use dev_id a

Re: [dpdk-dev] [RFC UPDATE PATCH 0/9] dmadev rfc suggested updates

2021-07-06 Thread fengchengwen
LGTM, thanks And I'am prepare dmadev V2, include: a) Fix code review comments (e.g. multiple-process support, doxygen, comments, typo) b) Flatten device abstraction to two layer: dmadev <> vchan c) Public API use dev_id and vchan_id to locate one vchan d) Using the flags parameter instead of the