Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread Thomas Monjalon
20/09/2021 22:11, Narcisa Ana Maria Vasile: > On Tue, Aug 24, 2021 at 04:21:03PM +, William Tu wrote: > > Currently there are some public headers that include 'sys/queue.h', which > > is not POSIX, but usually provided by the Linux/BSD system library. > > (Not in POSIX.1, POSIX.1-2001, or POSIX

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread Bruce Richardson
On Fri, Oct 01, 2021 at 11:55:47AM +0200, David Marchand wrote: > On Fri, Oct 1, 2021 at 11:51 AM Dmitry Kozlyuk > wrote: > > > > 2021-10-01 12:36 (UTC+0300), Dmitry Kozlyuk: > > > 2021-10-01 09:27 (UTC+0200), David Marchand: > > > > [...] > > > > I just have a concern that headers get broken aga

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread David Marchand
On Fri, Oct 1, 2021 at 11:51 AM Dmitry Kozlyuk wrote: > > 2021-10-01 12:36 (UTC+0300), Dmitry Kozlyuk: > > 2021-10-01 09:27 (UTC+0200), David Marchand: > > > [...] > > > I just have a concern that headers get broken again if we have no check. > > > Could buildtools/chkincs do the job (if we make t

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread Dmitry Kozlyuk
2021-10-01 12:36 (UTC+0300), Dmitry Kozlyuk: > 2021-10-01 09:27 (UTC+0200), David Marchand: > > [...] > > I just have a concern that headers get broken again if we have no check. > > Could buildtools/chkincs do the job (if we make this check work on > > Windows)? > > It's a valid caoncern and y

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread Dmitry Kozlyuk
2021-10-01 09:27 (UTC+0200), David Marchand: > [...] > I just have a concern that headers get broken again if we have no check. > Could buildtools/chkincs do the job (if we make this check work on Windows)? It's a valid caoncern and yes, chkincs would be a solution. I discovered that the real iss

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-10-01 Thread David Marchand
Hello William, On Fri, Oct 1, 2021 at 12:17 AM William Tu wrote: > > On Mon, Sep 20, 2021 at 1:11 PM Narcisa Ana Maria Vasile > wrote: > > > > On Tue, Aug 24, 2021 at 04:21:03PM +, William Tu wrote: > > > Currently there are some public headers that include 'sys/queue.h', which > > > is not

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-09-30 Thread William Tu
On Mon, Sep 20, 2021 at 1:11 PM Narcisa Ana Maria Vasile wrote: > > On Tue, Aug 24, 2021 at 04:21:03PM +, William Tu wrote: > > Currently there are some public headers that include 'sys/queue.h', which > > is not POSIX, but usually provided by the Linux/BSD system library. > > (Not in POSIX.1,

Re: [dpdk-dev] [PATCH v9] eal: remove sys/queue.h from public headers

2021-09-20 Thread Narcisa Ana Maria Vasile
On Tue, Aug 24, 2021 at 04:21:03PM +, William Tu wrote: > Currently there are some public headers that include 'sys/queue.h', which > is not POSIX, but usually provided by the Linux/BSD system library. > (Not in POSIX.1, POSIX.1-2001, or POSIX.1-2008. Present on the BSDs.) > The file is missing