Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

2018-04-26 Thread Ananyev, Konstantin
> -Original Message- > From: Doherty, Declan > Sent: Thursday, April 26, 2018 3:29 PM > To: Ananyev, Konstantin ; dev@dpdk.org > Cc: Adrien Mazarguil ; Yigit, Ferruh > ; Thomas Monjalon ; > Shahaf Shuler ; Horton, Remy > Subject: Re: [dpdk-dev][PATCH v8 6/9] et

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

2018-04-26 Thread Thomas Monjalon
26/04/2018 16:28, Doherty, Declan: > On 26/04/2018 1:03 PM, Ananyev, Konstantin wrote: > > From: Doherty, Declan > >> +typedef int (*rte_eth_devargs_callback_t)(char *str, void *data); > >> + > >> +static int > >> +rte_eth_devargs_tokenise(struct rte_kvargs *arglist, const char *str_in) > >> +{ > >

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

2018-04-26 Thread Remy Horton
On 26/04/2018 13:03, Ananyev, Konstantin wrote: [..] I still think that if you'd like to extend rte_kvarrgs to be able to parse something like: "key=[val1,val2,...,valn]", you have to make it generic kvargs ability and put it into librte_kvargs, not try to introduce your own new parser here. I

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

2018-04-26 Thread Doherty, Declan
On 26/04/2018 1:03 PM, Ananyev, Konstantin wrote: -Original Message- From: Doherty, Declan Sent: Thursday, April 26, 2018 11:41 AM To: dev@dpdk.org Cc: Adrien Mazarguil ; Yigit, Ferruh ; Thomas Monjalon ; Shahaf Shuler ; Ananyev, Konstantin ; Horton, Remy ; Doherty, Declan Subject:

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 1:03 PM, Ananyev, Konstantin wrote: > > >> -Original Message- >> From: Doherty, Declan >> Sent: Thursday, April 26, 2018 11:41 AM >> To: dev@dpdk.org >> Cc: Adrien Mazarguil ; Yigit, Ferruh >> ; Thomas Monjalon ; >> Shahaf Shuler ; Ananyev, Konstantin >> ; Horton, Remy ; >>

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

2018-04-26 Thread Ferruh Yigit
On 4/26/2018 11:41 AM, Declan Doherty wrote: > From: Remy Horton > > Introduces a new structure, rte_eth_devargs, to support generic > ethdev arguments common across NET PMDs, with a new API > rte_eth_devargs_parse API to support PMD parsing these arguments. The > patch add support for a represen

Re: [dpdk-dev] [PATCH v8 6/9] ethdev: add common devargs parser

2018-04-26 Thread Ananyev, Konstantin
> -Original Message- > From: Doherty, Declan > Sent: Thursday, April 26, 2018 11:41 AM > To: dev@dpdk.org > Cc: Adrien Mazarguil ; Yigit, Ferruh > ; Thomas Monjalon ; > Shahaf Shuler ; Ananyev, Konstantin > ; Horton, Remy ; > Doherty, Declan > Subject: [dpdk-dev][PATCH v8 6/9] ethdev: