Re: [dpdk-dev] [PATCH v8 4/9] eal/bus: support for scanning of bus

2017-01-17 Thread Thomas Monjalon
2017-01-18 05:15, Shreyansh Jain: > > > + * > > > + * @return > > > + * 0 for successful scan > > > + * !0 (<0) for unsuccessful scan with error value > > > > What do you mean with !0 (<0) ? > > I guess <0 is enough. > > > > Only to highlight that only '-ve' values would be returned. I

Re: [dpdk-dev] [PATCH v8 4/9] eal/bus: support for scanning of bus

2017-01-17 Thread Shreyansh Jain
> -Original Message- > From: Thomas Monjalon [mailto:thomas.monja...@6wind.com] > Sent: Wednesday, January 18, 2017 5:07 AM > To: Shreyansh Jain > Cc: dev@dpdk.org > Subject: Re: [PATCH v8 4/9] eal/bus: support for scanning of bus > > 2017-01-17 19:07, Shreyansh Jain: > > + * Generic bus

Re: [dpdk-dev] [PATCH v8 4/9] eal/bus: support for scanning of bus

2017-01-17 Thread Thomas Monjalon
2017-01-17 19:07, Shreyansh Jain: > + * Generic bus object passed only as a helper for implementation to find > + * their respective registered bus object. Implementations can choose not > + * to use this variable. I think this comment is obsolete. > + * > + * @return > + * 0 for successful s