Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

2021-11-01 Thread Ferruh Yigit
On 11/1/2021 12:48 PM, Ferruh Yigit wrote: On 11/1/2021 12:39 PM, Ferruh Yigit wrote: On 11/1/2021 9:23 AM, Jiawen Wu wrote: On October 22, 2021 7:03 PM, Ferruh Yigit wrote: diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 7b46ffb68635..0b0f9db7cb2a 10064

Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

2021-11-01 Thread Ferruh Yigit
On 11/1/2021 12:39 PM, Ferruh Yigit wrote: On 11/1/2021 9:23 AM, Jiawen Wu wrote: On October 22, 2021 7:03 PM, Ferruh Yigit wrote: diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 7b46ffb68635..0b0f9db7cb2a 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++

Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

2021-11-01 Thread Ferruh Yigit
On 11/1/2021 9:23 AM, Jiawen Wu wrote: On October 22, 2021 7:03 PM, Ferruh Yigit wrote: diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c index 7b46ffb68635..0b0f9db7cb2a 100644 --- a/drivers/net/txgbe/txgbe_ethdev.c +++ b/drivers/net/txgbe/txgbe_ethdev.c @@ -2695

Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

2021-11-01 Thread Jiawen Wu
On October 22, 2021 7:03 PM, Ferruh Yigit wrote: > > diff --git a/drivers/net/txgbe/txgbe_ethdev.c > b/drivers/net/txgbe/txgbe_ethdev.c > index 7b46ffb68635..0b0f9db7cb2a 100644 > --- a/drivers/net/txgbe/txgbe_ethdev.c > +++ b/drivers/net/txgbe/txgbe_ethdev.c > @@ -2695,11 +2695,11 @@ txgbe_dev_li

Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

2021-10-22 Thread Somnath Kotur
On Fri, 22 Oct 2021, 16:58 Andrew Rybchenko, wrote: > On 10/22/21 2:03 PM, Ferruh Yigit wrote: > > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > > LGTM except two lines duplicated above. > > > wa

Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

2021-10-22 Thread Ferruh Yigit
On Fri, 22 Oct 2021, 16:58 Andrew Rybchenko, mailto:andrew.rybche...@oktetlabs.ru>> wrote: On 10/22/21 2:03 PM, Ferruh Yigit wrote: > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible

Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

2021-10-22 Thread Ferruh Yigit
On 10/22/2021 12:28 PM, Andrew Rybchenko wrote: On 10/22/21 2:03 PM, Ferruh Yigit wrote: Add 'RTE_ETH' namespace to all enums & macros in a backward compatible Add 'RTE_ETH' namespace to all enums & macros in a backward compatible LGTM except two lines duplicated above. Thanks Andrew, I wil

Re: [dpdk-dev] [PATCH v7] ethdev: add namespace

2021-10-22 Thread Andrew Rybchenko
On 10/22/21 2:03 PM, Ferruh Yigit wrote: > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible > Add 'RTE_ETH' namespace to all enums & macros in a backward compatible LGTM except two lines duplicated above. > way. The macros for backward compatibility can be removed in next LT