Re: [dpdk-dev] [PATCH v6 5/5] net: replace Windows networking shim

2021-03-26 10:28 (UTC+0100), Thomas Monjalon: > 20/03/2021 14:05, Dmitry Kozlyuk: [...] > > --- a/drivers/net/i40e/i40e_fdir.c > > +++ b/drivers/net/i40e/i40e_fdir.c > > @@ -22,6 +22,7 @@ > > #include > > #include > > #include > > +#include > > Why is it needed? I deliberately put all sh

Re: [dpdk-dev] [PATCH v6 5/5] net: replace Windows networking shim

20/03/2021 14:05, Dmitry Kozlyuk: > Remove networking shim from Windows EAL. > > Replace it with system headers with two workarounds: > > 1. Windows Sockets headers contain `#define s_addr S_un.S_addr`, which >conflicts with `s_addr` field of `struct rte_ether_hdr`. Undefining >this macro