Re: [dpdk-dev] [PATCH v6 2/2] net: introduce IPv4 ihl and version fields

2021-10-14 Thread Gregory Etelson
Hello Thomas, > > > struct rte_ipv4_hdr { > > > - uint8_t version_ihl; /**< version > and header length */ > > > + __extension__ > > > + union { > > > + uint8_t version_ihl;/**< version > and header length */ > > > + struct { > > > +#if RTE_BYTE_ORDER ==

Re: [dpdk-dev] [PATCH v6 2/2] net: introduce IPv4 ihl and version fields

2021-10-14 Thread Thomas Monjalon
14/10/2021 17:11, Ferruh Yigit: > On 10/13/2021 6:13 PM, Gregory Etelson wrote: > > struct rte_ipv4_hdr { > > - uint8_t version_ihl; /**< version and header length */ > > + __extension__ > > + union { > > + uint8_t version_ihl;/**< version and header length */ > > +

Re: [dpdk-dev] [PATCH v6 2/2] net: introduce IPv4 ihl and version fields

2021-10-14 Thread Ferruh Yigit
On 10/13/2021 6:13 PM, Gregory Etelson wrote: struct rte_ipv4_hdr { - uint8_t version_ihl; /**< version and header length */ + __extension__ + union { + uint8_t version_ihl;/**< version and header length */ + struct { +#if RTE_BYTE_OR