Re: [dpdk-dev] [PATCH v6 2/2] mbuf: implement generic format for sched field

2018-12-20 Thread Olivier Matz
Hi Cristian, [...] On Thu, Dec 20, 2018 at 11:28:01AM +, Dumitrescu, Cristian wrote: > > > + * @param m > > > + * Mbuf to read > > > + * @param queue_id > > > + * Returns the queue id > > > + * @param traffic_class > > > + * Returns the traffic class id > > > + * @param color > > > + * R

Re: [dpdk-dev] [PATCH v6 2/2] mbuf: implement generic format for sched field

2018-12-20 Thread Dumitrescu, Cristian
Hi Olivier, Thanks for your reply! > > * The generic rte_mbuf, containing a packet mbuf. > > */ > > @@ -574,14 +585,16 @@ struct rte_mbuf { > > * on PKT_RX_FDIR_* flag in ol_flags. > > */ > > } fdir; /**< Filter i

Re: [dpdk-dev] [PATCH v6 2/2] mbuf: implement generic format for sched field

2018-12-20 Thread Olivier Matz
Hi Reshma, Please find few minor comments below. On Wed, Dec 19, 2018 at 03:42:37PM +, Reshma Pattan wrote: > This patch implements the changes proposed in the deprecation > notes [1][2]. > > librte_mbuf changes: > The mbuf::hash::sched field is updated to support generic I think it would b

Re: [dpdk-dev] [PATCH v6 2/2] mbuf: implement generic format for sched field

2018-12-19 Thread Ananyev, Konstantin
> -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Reshma Pattan > Sent: Wednesday, December 19, 2018 3:43 PM > To: dev@dpdk.org; jerin.ja...@caviumnetworks.com; Rao, Nikhil > ; olivier.m...@6wind.com; > tho...@monjalon.net; Singh, Jasvinder ; > Dumitrescu, Cri