Re: [dpdk-dev] [PATCH v6 1/3] eal: introduce integer divide through reciprocal

2017-09-20 Thread Pavan Nikhilesh Bhagavatula
On Wed, Sep 20, 2017 at 01:10:53PM +, Dumitrescu, Cristian wrote: > Hi Pavan, Hi Cristian, > > I think moving rte_reciprocal.[hc] to a common code area like EAL is a very > good idea, so thanks for doing this work! > > One ask from my side: please do not change the existing code. > 1. Keep the

Re: [dpdk-dev] [PATCH v6 1/3] eal: introduce integer divide through reciprocal

2017-09-20 Thread Dumitrescu, Cristian
Hi Pavan, I think moving rte_reciprocal.[hc] to a common code area like EAL is a very good idea, so thanks for doing this work! One ask from my side: please do not change the existing code. 1. Keep the existing name for the 32-bit API functions and data structures (no _u32 name suffix), add the