Re: [dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-11 Thread Andrew Rybchenko
On 10/11/21 7:52 PM, Ananyev, Konstantin wrote: On 10/7/21 2:27 PM, Konstantin Ananyev wrote: Copy public function pointers (rx_pkt_burst(), etc.) and related pointers to internal data from rte_eth_dev structure into a separate flat array. That array will remain in a public header. The intent

Re: [dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-11 Thread Ananyev, Konstantin
> On 10/7/21 2:27 PM, Konstantin Ananyev wrote: > > Copy public function pointers (rx_pkt_burst(), etc.) and related > > pointers to internal data from rte_eth_dev structure into a > > separate flat array. That array will remain in a public header. > > The intention here is to make rte_eth_dev an

Re: [dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-11 Thread Ananyev, Konstantin
> > Sorry to self-reply. > > I think it's better the 'struct rte_eth_dev *dev' hold a pointer to the > 'struct rte_eth_fp_ops', e.g. > > struct rte_eth_dev { > struct rte_eth_fp_ops *fp_ops; > ... // other field > } > > The eth framework set the pointer

Re: [dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-11 Thread Ananyev, Konstantin
> > Copy public function pointers (rx_pkt_burst(), etc.) and related > > pointers to internal data from rte_eth_dev structure into a > > separate flat array. That array will remain in a public header. > > The intention here is to make rte_eth_dev and related structures internal. > > That should al

Re: [dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-11 Thread Andrew Rybchenko
On 10/11/21 4:18 AM, fengchengwen wrote: > Sorry to self-reply. > > I think it's better the 'struct rte_eth_dev *dev' hold a pointer to the > 'struct rte_eth_fp_ops', e.g. > > struct rte_eth_dev { > struct rte_eth_fp_ops *fp_ops; > ... // other field > } >

Re: [dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-11 Thread Andrew Rybchenko
On 10/9/21 3:05 PM, fengchengwen wrote: > On 2021/10/7 19:27, Konstantin Ananyev wrote: >> Copy public function pointers (rx_pkt_burst(), etc.) and related >> pointers to internal data from rte_eth_dev structure into a >> separate flat array. That array will remain in a public header. >> The intent

Re: [dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-11 Thread Andrew Rybchenko
On 10/7/21 2:27 PM, Konstantin Ananyev wrote: > Copy public function pointers (rx_pkt_burst(), etc.) and related > pointers to internal data from rte_eth_dev structure into a > separate flat array. That array will remain in a public header. > The intention here is to make rte_eth_dev and related st

Re: [dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-10 Thread fengchengwen
Sorry to self-reply. I think it's better the 'struct rte_eth_dev *dev' hold a pointer to the 'struct rte_eth_fp_ops', e.g. struct rte_eth_dev { struct rte_eth_fp_ops *fp_ops; ... // other field } The eth framework set the pointer in the rte_eth_de

Re: [dpdk-dev] [PATCH v5 4/7] ethdev: copy fast-path API into separate structure

2021-10-09 Thread fengchengwen
On 2021/10/7 19:27, Konstantin Ananyev wrote: > Copy public function pointers (rx_pkt_burst(), etc.) and related > pointers to internal data from rte_eth_dev structure into a > separate flat array. That array will remain in a public header. > The intention here is to make rte_eth_dev and related st