Re: [dpdk-dev] [PATCH v5 2/5] ethdev: increase port_id range

2017-09-27 Thread Yang, Zhiyong
Ferruh, > There is a patch to add missing ones [1], I think it would be better to add > them > with a separate patch. > > But I missed the "librte_pmd_vhost" one, I will send a new version soon. > > Also failsafe don't have any PMD specific API, no need to add it. > > > [1] > http://dpdk.org/

Re: [dpdk-dev] [PATCH v5 2/5] ethdev: increase port_id range

2017-09-27 Thread Ferruh Yigit
On 9/26/2017 8:01 AM, Yang, Zhiyong wrote: > Hi Ferruh, Thomas, > >>> @@ -40,7 +40,7 @@ LIB = librte_pmd_af_packet.a >>> >>> EXPORT_MAP := rte_pmd_af_packet_version.map >>> >>> -LIBABIVER := 1 >>> +LIBABIVER := 2 >> >> I have just recognized this one. This shouldn't be updated. Only LIABIVER of

Re: [dpdk-dev] [PATCH v5 2/5] ethdev: increase port_id range

2017-09-26 Thread Yang, Zhiyong
Hi Ferruh, Thomas, > > @@ -40,7 +40,7 @@ LIB = librte_pmd_af_packet.a > > > > EXPORT_MAP := rte_pmd_af_packet_version.map > > > > -LIBABIVER := 1 > > +LIBABIVER := 2 > > I have just recognized this one. This shouldn't be updated. Only LIABIVER of > the > libraries that their API modified should

Re: [dpdk-dev] [PATCH v5 2/5] ethdev: increase port_id range

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 4:22 AM, Zhiyong Yang wrote: > Extend port_id definition from uint8_t to uint16_t in lib and drivers > data structures, specifically rte_eth_dev_data. Modify the APIs, > drivers and app using port_id at the same time. > > Fix some checkpatch issues from the original code and remove so

Re: [dpdk-dev] [PATCH v5 2/5] ethdev: increase port_id range

2017-09-25 Thread Ferruh Yigit
On 9/25/2017 4:22 AM, Zhiyong Yang wrote: > Extend port_id definition from uint8_t to uint16_t in lib and drivers > data structures, specifically rte_eth_dev_data. Modify the APIs, > drivers and app using port_id at the same time. > > Fix some checkpatch issues from the original code and remove so