Re: [dpdk-dev] [PATCH v5 16/19] devargs: introduce cleaner parsing helper

2017-07-04 Thread Gaƫtan Rivet
Hi Keith, Thanks for the review. On Tue, Jun 27, 2017 at 11:46:48PM +, Wiles, Keith wrote: > > > On Jun 20, 2017, at 4:35 PM, Gaetan Rivet wrote: > > > > Introduce a more versatile helper to parse device strings. This > > helper expects a generic rte_devargs structure as storage in order n

Re: [dpdk-dev] [PATCH v5 16/19] devargs: introduce cleaner parsing helper

2017-06-27 Thread Wiles, Keith
> On Jun 20, 2017, at 4:35 PM, Gaetan Rivet wrote: > > Introduce a more versatile helper to parse device strings. This > helper expects a generic rte_devargs structure as storage in order not > to require any API changes in the future, should this structure be > updated. > > The old equivalent

Re: [dpdk-dev] [PATCH v5 16/19] devargs: introduce cleaner parsing helper

2017-06-27 Thread Thomas Monjalon
21/06/2017 01:35, Gaetan Rivet: > +int > +rte_eal_devargs_parse(const char *dev, > + struct rte_devargs *da); You need to export this new function: --- a/lib/librte_eal/bsdapp/eal/rte_eal_version.map +++ b/lib/librte_eal/bsdapp/eal/rte_eal_version.map @@ -203,6 +203,7 @@ DPDK_17