Re: [dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup

2017-09-28 Thread Shreyansh Jain
On Thursday 21 September 2017 06:29 PM, Shreyansh Jain wrote: Hello Ferruh, Apologies for delay in response for these, I am already working to get the next version based on your comments. Meanwhile, some comments inline... On Monday 18 September 2017 08:25 PM, Ferruh Yigit wrote: On 9/9/2017

Re: [dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup

2017-09-21 Thread Shreyansh Jain
On Monday 18 September 2017 08:25 PM, Ferruh Yigit wrote: On 9/9/2017 12:21 PM, Shreyansh Jain wrote: Signed-off-by: Hemant Agrawal Signed-off-by: Shreyansh Jain <...> + +/* Handle all mbufs on an external pool (non-dpaa2) */ minor typo, but is intention dpaa ? Yes, this is 'dpaa'.

Re: [dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup

2017-09-21 Thread Shreyansh Jain
Hello Ferruh, Apologies for delay in response for these, I am already working to get the next version based on your comments. Meanwhile, some comments inline... On Monday 18 September 2017 08:25 PM, Ferruh Yigit wrote: On 9/9/2017 12:21 PM, Shreyansh Jain wrote: Signed-off-by: Hemant Agrawal

Re: [dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > + > +/* Handle all mbufs on an external pool (non-dpaa2) */ minor typo, but is intention dpaa ? > +static inline uint16_t > +tx_on_external_pool(struct qman_fq *txq, struct rte_

Re: [dpdk-dev] [PATCH v4 25/41] net/dpaa: add support for Tx and Rx queue setup

2017-09-18 Thread Ferruh Yigit
On 9/9/2017 12:21 PM, Shreyansh Jain wrote: > Signed-off-by: Hemant Agrawal > Signed-off-by: Shreyansh Jain <...> > + for (loop = 0; loop < num_cores; loop++) { > + ret = dpaa_tx_queue_init(&dpaa_intf->tx_queues[loop], > + fman_intf); > +