Re: [dpdk-dev] [PATCH v4 12/14] acl: deduplicate AVX512 code paths

2020-10-16 Thread Thomas Monjalon
16/10/2020 17:56, Ferruh Yigit: > On 10/6/2020 4:03 PM, Konstantin Ananyev wrote: > > @@ -120,7 +161,7 @@ _m256_mask_gather_epi8x4(__m256i pdata, __mmask8 mask) > > > > static const uint32_t zero; > > icc complains about this, although it is static [1]. > Would it be acceptable to initializ

Re: [dpdk-dev] [PATCH v4 12/14] acl: deduplicate AVX512 code paths

2020-10-16 Thread Ferruh Yigit
On 10/6/2020 4:03 PM, Konstantin Ananyev wrote: Current rte_acl_classify_avx512x32() and rte_acl_classify_avx512x16() code paths are very similar. The only differences are due to 256/512 register/instrincts naming conventions. So to deduplicate the code: - Move common code into “acl_run_avx512