Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Thomas Monjalon
14/03/2020 00:38, Dmitry Kozlyuk: > > I suggest this change (I can send a patch fixing the issue in other .h > > files): > > > > +/* > > + * RTE_TOOLCHAIN_GCC is true if the target is built with GCC, > > + * while a host application (like pmdinfogen) may have another compiler. > > + * RTE_CC_IS_GN

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Bruce Richardson
On Mon, Mar 16, 2020 at 12:14:51PM +0100, Thomas Monjalon wrote: > 16/03/2020 12:02, Bruce Richardson: > > On Mon, Mar 16, 2020 at 10:54:09AM +, Bruce Richardson wrote: > > > On Sun, Mar 15, 2020 at 09:36:11AM +0100, Thomas Monjalon wrote: > > > > 14/03/2020 00:38, Dmitry Kozlyuk: > > > > > > I

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Bruce Richardson
On Mon, Mar 16, 2020 at 12:14:51PM +0100, Thomas Monjalon wrote: > 16/03/2020 12:02, Bruce Richardson: > > On Mon, Mar 16, 2020 at 10:54:09AM +, Bruce Richardson wrote: > > > On Sun, Mar 15, 2020 at 09:36:11AM +0100, Thomas Monjalon wrote: > > > > 14/03/2020 00:38, Dmitry Kozlyuk: > > > > > > I

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Thomas Monjalon
16/03/2020 12:02, Bruce Richardson: > On Mon, Mar 16, 2020 at 10:54:09AM +, Bruce Richardson wrote: > > On Sun, Mar 15, 2020 at 09:36:11AM +0100, Thomas Monjalon wrote: > > > 14/03/2020 00:38, Dmitry Kozlyuk: > > > > > I suggest this change (I can send a patch fixing the issue in other > > > >

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Bruce Richardson
On Mon, Mar 16, 2020 at 10:54:09AM +, Bruce Richardson wrote: > On Sun, Mar 15, 2020 at 09:36:11AM +0100, Thomas Monjalon wrote: > > 14/03/2020 00:38, Dmitry Kozlyuk: > > > > I suggest this change (I can send a patch fixing the issue in other .h > > > > files): > > > > > > > > +/* > > > > + *

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-16 Thread Bruce Richardson
On Sun, Mar 15, 2020 at 09:36:11AM +0100, Thomas Monjalon wrote: > 14/03/2020 00:38, Dmitry Kozlyuk: > > > I suggest this change (I can send a patch fixing the issue in other .h > > > files): > > > > > > +/* > > > + * RTE_TOOLCHAIN_GCC is true if the target is built with GCC, > > > + * while a hos

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-15 Thread Thomas Monjalon
14/03/2020 00:38, Dmitry Kozlyuk: > > I suggest this change (I can send a patch fixing the issue in other .h > > files): > > > > +/* > > + * RTE_TOOLCHAIN_GCC is true if the target is built with GCC, > > + * while a host application (like pmdinfogen) may have another compiler. > > + * RTE_CC_IS_GN

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-13 Thread Dmitry Kozlyuk
> I suggest this change (I can send a patch fixing the issue in other .h files): > > +/* > + * RTE_TOOLCHAIN_GCC is true if the target is built with GCC, > + * while a host application (like pmdinfogen) may have another compiler. > + * RTE_CC_IS_GNU is true if the file is compiled with GCC, > + * n

Re: [dpdk-dev] [PATCH v4 1/7] eal: introduce portable format attribute

2020-03-12 Thread Thomas Monjalon
27/02/2020 05:25, Dmitry Kozlyuk: > When using __attribute__((format(...)) on functions, GCC on Windows > assumes MS-specific format string by default, even if the underlying > stdio implementation is ANSI-compliant (either MS Unicersal CRT > or MinGW implementation). Wrap attribute into a macro th