Thanks Stephen for your review and suggestion, I will involve them in next
version.
Best regards,
Jeff Guo
-Original Message-
From: Stephen Hemminger [mailto:step...@networkplumber.org]
Sent: Monday, September 4, 2017 12:12 AM
To: Guo, Jia
Cc: Richardson, Bruce ; dev@dpdk.org;
gaetan.
On Sun, 3 Sep 2017 23:49:44 +0800
Jeff Guo wrote:
> + /**
> + * add device uevent file descriptor
> + * into wait list for uevent monitoring.
> + */
> + ev.events = EPOLLIN | EPOLLPRI | EPOLLRD
On Sun, 3 Sep 2017 23:49:44 +0800
Jeff Guo wrote:
> + char buf[RTE_EAL_UEVENT_MSG_LEN];
> +
> + memset(uevent, 0, sizeof(struct rte_eal_uevent));
> + memset(buf, 0, RTE_EAL_UEVENT_MSG_LEN);
Please don't initialize everything all the time; you are even initializing
receive data.
>
On Sun, 3 Sep 2017 23:49:44 +0800
Jeff Guo wrote:
> +int
> +rte_eal_uev_enable(int netlink_fd)
> +{
> + struct sockaddr_nl addr;
> + int ret;
> + int size = 64 * 1024;
> + int nonblock = 1;
> + memset(&addr, 0, sizeof(addr));
Blank line between declarations and code.
Also us
On Sun, 3 Sep 2017 23:49:44 +0800
Jeff Guo wrote:
> +int
> +rte_eal_uev_fd_new(void)
> +{
> +
> + int netlink_fd = -1;
> +
> + netlink_fd = socket(PF
Please don't use the "initialize everything" style of programming.
Gcc has good detection and warning about uninitalized variables, and
5 matches
Mail list logo
