subject:"Re\: \[dpdk\-dev\] \[PATCH v3 6\/9\] ipsec\: implement SA data\-path API"

Re: [dpdk-dev] [PATCH v3 6/9] ipsec: implement SA data-path API

2018-12-13 Thread Ananyev, Konstantin

Hi Declan, > > Only some minor some cosmetic questions > > On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: > > Provide implementation for rte_ipsec_pkt_crypto_prepare() and > ... > > > +/* > > + * Move preceding (L3) headers up to free space for ESP header and IV. > > + */ > > +static inline v

Re: [dpdk-dev] [PATCH v3 6/9] ipsec: implement SA data-path API

2018-12-12 Thread Doherty, Declan

Only some minor some cosmetic questions On 06/12/2018 3:38 PM, Konstantin Ananyev wrote: Provide implementation for rte_ipsec_pkt_crypto_prepare() and ... +/* + * Move preceding (L3) headers up to free space for ESP header and IV. + */ +static inline void +insert_esph(char *np, char *op, uint