Re: [dpdk-dev] [PATCH v3 3/9] mem: fix potential double close

2018-04-27 Thread Burakov, Anatoly
On 27-Apr-18 4:15 PM, Bruce Richardson wrote: On Wed, Apr 25, 2018 at 10:56:41AM +0100, Anatoly Burakov wrote: We were closing descriptor before checking if mapping has failed, but if it did, we did a second close afterwards. Fix it by moving closing descriptor to after we check if mmap has succ

Re: [dpdk-dev] [PATCH v3 3/9] mem: fix potential double close

2018-04-27 Thread Bruce Richardson
On Wed, Apr 25, 2018 at 10:56:41AM +0100, Anatoly Burakov wrote: > We were closing descriptor before checking if mapping has > failed, but if it did, we did a second close afterwards. Fix > it by moving closing descriptor to after we check if mmap has > succeeded. > > Coverity issue: 272560 > > F