Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API

2019-06-20 Thread Yang, Qiming
Hi, Xiao Other comments are all fixed. Left this one. "fields & (~inset)" can't replace it. Qiming -Original Message- From: Wang, Xiao W Sent: Thursday, June 20, 2019 5:32 PM To: Yang, Qiming ; dev@dpdk.org Cc: Zhang, Qi Z ; Xing, Beilei Subject: RE: [dpdk-dev] [PA

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API

2019-06-20 Thread Yang, Qiming
Thanks for your comments. I'll add it in v4. > -Original Message- > From: Aaron Conole [mailto:acon...@redhat.com] > Sent: Thursday, June 20, 2019 9:34 PM > To: Yang, Qiming > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API &

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API

2019-06-20 Thread Aaron Conole
Qiming Yang writes: > This patch adds ice_flow_create, ice_flow_destroy, > ice_flow_flush and ice_flow_validate support, > these are used to handle all the generic filters. > > Signed-off-by: Qiming Yang > --- > drivers/net/ice/Makefile | 1 + > drivers/net/ice/ice_ethdev.c |

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API

2019-06-20 Thread Wang, Xiao W
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Thursday, June 20, 2019 1:35 PM > To: dev@dpdk.org > Cc: Yang, Qiming > Subject: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API > > This patch adds ice_flow_create, ice_flow_destr

Re: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API

2019-06-20 Thread Wang, Xiao W
Hi, > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang > Sent: Thursday, June 20, 2019 1:35 PM > To: dev@dpdk.org > Cc: Yang, Qiming > Subject: [dpdk-dev] [PATCH v3 2/3] net/ice: add generic flow API > > This patch adds ice_flow_create, ice_flow_destr