Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and unbind APIs

2020-10-15 Thread Thomas Monjalon
15/10/2020 04:56, Bing Zhao: > From: Thomas Monjalon > > 08/10/2020 14:05, Bing Zhao: > > > +int > > > +rte_eth_hairpin_bind(uint16_t tx_port, uint16_t rx_port) { > > > + struct rte_eth_dev *dev; > > > + int ret; > > > + > > > + RTE_ETH_VALID_PORTID_OR_ERR_RET(tx_port, -EINVAL); > > >

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and unbind APIs

2020-10-14 Thread Bing Zhao
beilei.x...@intel.com; > wenzhuo...@intel.com; dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and > unbind APIs > > External email: Use caution opening links or attachments > > > Hi, > Cosmetic comments below: > > 08/10/2020 14:05, Bing Zha

Re: [dpdk-dev] [PATCH v3 1/6] ethdev: add hairpin bind and unbind APIs

2020-10-14 Thread Thomas Monjalon
Hi, Cosmetic comments below: 08/10/2020 14:05, Bing Zhao: > +int > +rte_eth_hairpin_bind(uint16_t tx_port, uint16_t rx_port) > +{ > + struct rte_eth_dev *dev; > + int ret; > + > + RTE_ETH_VALID_PORTID_OR_ERR_RET(tx_port, -EINVAL); It should be -ENODEV > + dev = &rte_eth_devices[t