Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add access to eeprom

2018-04-22 Thread Thomas Monjalon
Hi Zijie, 21/03/2018 12:06, Zijie Pan: > +/* > + * Placeholder for accessing plugin module eeprom > + */ I think you missed a "*" to make it a doxygen comment. > +struct rte_dev_module_info { > + uint32_t type; /**< Type of plugin module eeprom */ > + uint32_t eeprom_len; /**< Length of

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add access to eeprom

2018-04-20 Thread Zijie Pan
n"; "john.mcnamara"; "marko.kovacevic"; "thomas"; Subject: Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add access to eeprom On 3/21/2018 11:06 AM, Zijie Pan wrote: > --- a/lib/librte_ether/rte_ethdev_version.map > +++ b/lib/librt

Re: [dpdk-dev] [PATCH v3 1/5] ethdev: add access to eeprom

2018-04-19 Thread Ferruh Yigit
On 3/21/2018 11:06 AM, Zijie Pan wrote: > --- a/lib/librte_ether/rte_ethdev_version.map > +++ b/lib/librte_ether/rte_ethdev_version.map > @@ -201,6 +201,8 @@ DPDK_18.02 { > global: > > rte_eth_dev_filter_ctrl; > + rte_eth_dev_get_module_info; > + rte_eth_dev_get_module_eeprom;