Re: [dpdk-dev] [PATCH v3 1/4] net/virtio: fix add pointer checking

2018-03-29 Thread Maxime Coquelin
On 03/21/2018 04:03 AM, zhiyong.y...@intel.com wrote: It is necessary to add pointer checking because in some case the code will cause crash. For example, the code goes here before memory allocation of rxvq is finished. Fixes: 7365504f77e3("net/virtio: support guest announce") Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH v3 1/4] net/virtio: fix add pointer checking

2018-03-29 Thread Maxime Coquelin
On 03/21/2018 04:03 AM, zhiyong.y...@intel.com wrote: It is necessary to add pointer checking because in some case the code will cause crash. For example, the code goes here before memory allocation of rxvq is finished. Fixes: 7365504f77e3("net/virtio: support guest announce") Cc: sta...@dpdk.

Re: [dpdk-dev] [PATCH v3 1/4] net/virtio: fix add pointer checking

2018-03-28 Thread Yang, Zhiyong
> -Original Message- > From: Tan, Jianfeng > Sent: Wednesday, March 28, 2018 3:26 PM > To: Yang, Zhiyong ; dev@dpdk.org > Cc: Wang, Zhihong ; > maxime.coque...@redhat.com; tho...@monjalon.net; Wang, Dong1 > ; Bie, Tiwei ; > sta...@dpdk.org > Subject: Re: [PATCH v3 1/4] net/virtio: fix add

Re: [dpdk-dev] [PATCH v3 1/4] net/virtio: fix add pointer checking

2018-03-28 Thread Tan, Jianfeng
On 3/21/2018 11:03 AM, zhiyong.y...@intel.com wrote: It is necessary to add pointer checking because in some case the code will cause crash. For example, the code goes here before memory allocation of rxvq is finished. Fixes: 7365504f77e3("net/virtio: support guest announce") Cc: sta...@dpdk.o