Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support

2020-04-07 Thread Jerin Jacob
On Mon, Apr 6, 2020 at 9:39 PM Andrzej Ostruszka wrote: > > On 4/6/20 4:59 PM, Jerin Jacob wrote: > > On Mon, Apr 6, 2020 at 6:06 PM Andrzej Ostruszka wrote: > [...] > >>> +typedef uint32_t rte_graph_off_t; /**< Graph offset type. */ > >>> +typedef uint32_t rte_node_t; /**< Node id type. *

Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support

2020-04-06 Thread Andrzej Ostruszka
On 4/6/20 4:59 PM, Jerin Jacob wrote: > On Mon, Apr 6, 2020 at 6:06 PM Andrzej Ostruszka wrote: [...] >>> +typedef uint32_t rte_graph_off_t; /**< Graph offset type. */ >>> +typedef uint32_t rte_node_t; /**< Node id type. */ >>> +typedef uint16_t rte_edge_t; /**< Edge id type. */ >>> +

Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support

2020-04-06 Thread Jerin Jacob
On Mon, Apr 6, 2020 at 6:06 PM Andrzej Ostruszka wrote: > > Hello Jerin Hello Andrzej, > > I've started reviewing this and will go patch-by-patch so some of the > comments might sound silly and/or unnecessary. Thanks for the comments. > > + > > +/** > > + * @file rte_graph.h > > + * > > + *

Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support

2020-04-06 Thread Andrzej Ostruszka
Hello Jerin I've started reviewing this and will go patch-by-patch so some of the comments might sound silly and/or unnecessary. On 3/31/20 9:29 PM, jer...@marvell.com wrote: > From: Jerin Jacob > > Graph architecture abstracts the data processing functions as > "node" and "link" them together

Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support

2020-04-04 Thread Jerin Jacob
On Fri, Apr 3, 2020 at 2:56 PM Wang, Xiao W wrote: > > Hi Jerin, Hi Xiao. Thanks for the review. > Found small typos on this patch. Please check comments inline. > > Best Regards, > Xiao > > > +/** > > + * @warning > > + * @b EXPERIMENTAL: this API may change without prior notice > > + * > > + *

Re: [dpdk-dev] [PATCH v3 01/29] graph: define the public API for graph support

2020-04-03 Thread Wang, Xiao W
Hi Jerin, Found small typos on this patch. Please check comments inline. Best Regards, Xiao > -Original Message- > From: dev On Behalf Of jer...@marvell.com > Sent: Wednesday, April 1, 2020 3:29 AM > To: Thomas Monjalon ; Richardson, Bruce > ; Mcnamara, John ; > Kovacevic, Marko ; Jerin