Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-08 Thread Thomas Monjalon
08/10/2018 14:58, Joseph, Anoob: > On 08-10-2018 18:03, Thomas Monjalon wrote: > > A lot of patches are split in 2 parts for common/cpt and crypto/octeontx. > > I think it is useless most of the time. > > You are allowed to update any related code in the common part > > while implementing some feat

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-08 Thread Joseph, Anoob
Hi Thomas, On 08-10-2018 18:03, Thomas Monjalon wrote: External Email 05/10/2018 14:58, Anoob Joseph: Ankur Dwivedi (5): common/cpt: add common logging support config: add Cavium OCTEONTX crypto PMD skeleton crypto/octeontx: add register addresses common/cpt: add common code for in

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-08 Thread Thomas Monjalon
05/10/2018 14:58, Anoob Joseph: > Ankur Dwivedi (5): > common/cpt: add common logging support > config: add Cavium OCTEONTX crypto PMD skeleton > crypto/octeontx: add register addresses > common/cpt: add common code for init routine > test: adds validation test > > Anoob Joseph (5): >

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-05 Thread Joseph, Anoob
Hi Akhil, v2: * Moved common code identified for crypto devices of OCTEON TX family to common/cpt. * Divided the patches to make sure one feature gets added with one patch. * Addressed indentation issues. * Addressed comments from Jerin and Pablo. v3: * Merged v2-0001* & v2-0003* patch (Akhil)

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-05 Thread Akhil Goyal
On 10/5/2018 6:43 PM, Joseph, Anoob wrote: Hi Akhil, Do you want me to send revised cover letter patch or just summarizing it over email would do? You could do it as you prefer. Just wanted to know the changes that were done in every version that are sent. Thanks, Anoob On 05-10-2018 18:3

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-05 Thread Joseph, Anoob
Hi Akhil, Do you want me to send revised cover letter patch or just summarizing it over email would do? Thanks, Anoob On 05-10-2018 18:34, Akhil Goyal wrote: External Email Hi Anoob, Could you please add the change log in the cover note. Thanks, Akhil On 10/5/2018 6:28 PM, Anoob Joseph wr

Re: [dpdk-dev] [PATCH v3 00/32] Adding Cavium's OCTEONTX crypto PMD

2018-10-05 Thread Akhil Goyal
Hi Anoob, Could you please add the change log in the cover note. Thanks, Akhil On 10/5/2018 6:28 PM, Anoob Joseph wrote: Ankur Dwivedi (5): common/cpt: add common logging support config: add Cavium OCTEONTX crypto PMD skeleton crypto/octeontx: add register addresses common/cpt: add