Re: [dpdk-dev] [PATCH v3] net/softnic: fix memory leak in parsing arguments

> -Original Message- > From: Singh, Jasvinder > Sent: Wednesday, July 14, 2021 7:08 PM > To: Yu, DapengX ; Dumitrescu, Cristian > > Cc: dev@dpdk.org; sta...@dpdk.org > Subject: RE: [PATCH v3] net/softnic: fix memory leak in parsing arguments > > > > > + free(firmware); > > Memory

Re: [dpdk-dev] [PATCH v3] net/softnic: fix memory leak in parsing arguments

> + free(firmware); Memory for firmware is not allocated dynamically, so no need for this. > struct pmd_params { > - const char *name; > - const char *firmware; > + char name[RTE_DEV_NAME_MAX_LEN]; Please replace " RTE_DEV_NAME_MAX_LEN " with "NAME_SIZE" which is already de