Re: [dpdk-dev] [PATCH v3] net/ipn3ke: setup MTU when HW init

2019-09-03 Thread Pei, Andy
Oh, I misuse () when casting. Now it works. -Original Message- From: Ye, Xiaolong Sent: Tuesday, September 3, 2019 4:35 PM To: Pei, Andy Cc: dev@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh ; Xu, Rosen Subject: Re: [PATCH v3] net/ipn3ke: setup MTU when HW init On 09/03, Pei, Andy wrote: >Hi

Re: [dpdk-dev] [PATCH v3] net/ipn3ke: setup MTU when HW init

2019-09-03 Thread Ye Xiaolong
On 09/03, Pei, Andy wrote: >Hi Xiaolong, > >I tried, but compile issue exist. Er, what's the exact compiling issue after the type cast? We can see the similar usage in function like replay_num_bucket @lib/librte_ipsec/sa.c. Thanks, Xiaolong > >-Original Message- >From: Ye, Xiaolong >Sent

Re: [dpdk-dev] [PATCH v3] net/ipn3ke: setup MTU when HW init

2019-09-02 Thread Pei, Andy
Hi Xiaolong, I tried, but compile issue exist. -Original Message- From: Ye, Xiaolong Sent: Tuesday, September 3, 2019 2:23 PM To: Pei, Andy Cc: dev@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh ; Xu, Rosen Subject: Re: [PATCH v3] net/ipn3ke: setup MTU when HW init On 09/03, Pei, Andy wrote:

Re: [dpdk-dev] [PATCH v3] net/ipn3ke: setup MTU when HW init

2019-09-02 Thread Ye Xiaolong
On 09/03, Pei, Andy wrote: [snip] > tmp = RTE_MAX(tmp, RTE_ETHER_MIN_MTU); > >>+ if (tmp > IPN3KE_MAC_FRAME_SIZE_MAX - IPN3KE_ETH_OVERHEAD) >>+ tmp = IPN3KE_MAC_FRAME_SIZE_MAX - IPN3KE_ETH_OVERHEAD; > > tmp = RTE_MIN(tmp, IPN3KE_MAC_FRAME_SIZE_MAX - IPN3KE_ETH_OVERHEAD);

Re: [dpdk-dev] [PATCH v3] net/ipn3ke: setup MTU when HW init

2019-09-02 Thread Pei, Andy
HI Xiaolong, Reply inline. -Original Message- From: Ye, Xiaolong Sent: Monday, September 2, 2019 5:24 PM To: Pei, Andy Cc: dev@dpdk.org; Zhang, Qi Z ; Yigit, Ferruh ; Xu, Rosen Subject: Re: [PATCH v3] net/ipn3ke: setup MTU when HW init Hi, Andy On 09/02, Andy Pei wrote: >set up mtu

Re: [dpdk-dev] [PATCH v3] net/ipn3ke: setup MTU when HW init

2019-09-02 Thread Ye Xiaolong
Hi, Andy On 09/02, Andy Pei wrote: >set up mtu to the minimun in tx mtu, rx mtu and IPN3KE_MAC_FRAME_SIZE_MAX. > >Signed-off-by: Andy Pei >--- >Cc: qi.z.zh...@intel.com >Cc: ferruh.yi...@intel.com >Cc: rosen...@intel.com >Cc: xiaolong...@intel.com > >v2: >modify low bound and upper bound. > >v3: