Re: [dpdk-dev] [PATCH v2] net/virtio: fix Virtio-PCI ops assignment

2021-02-02 Thread Ferruh Yigit
On 2/2/2021 10:03 AM, David Marchand wrote: On Mon, Feb 1, 2021 at 9:33 PM Maxime Coquelin wrote: VIRTIO_OPS() macro relies on the port ID stored in the virtio_hw struct. Issue is that it is used before being assigned at init time. It results in all devices setting ops on port ID 0, causing cr

Re: [dpdk-dev] [PATCH v2] net/virtio: fix Virtio-PCI ops assignment

2021-02-02 Thread Ling, WeiX
Tested-by: Wei Ling > -Original Message- > From: Maxime Coquelin > Sent: Tuesday, February 2, 2021 04:32 AM > To: dev@dpdk.org; Wang, Yinan ; Xia, Chenbo > ; amore...@redhat.com; > david.march...@redhat.com; Ling, WeiX ; Jiang, YuX > > Cc: Maxime Coquelin > Subject: [PATCH v2] net/virt

Re: [dpdk-dev] [PATCH v2] net/virtio: fix Virtio-PCI ops assignment

2021-02-02 Thread David Marchand
On Mon, Feb 1, 2021 at 9:33 PM Maxime Coquelin wrote: > > VIRTIO_OPS() macro relies on the port ID stored in the > virtio_hw struct. Issue is that it is used before being > assigned at init time. It results in all devices setting > ops on port ID 0, causing crash later when calling ops > for port