Re: [dpdk-dev] [PATCH v2] net/virtio: add Tx preparation

On Wed, Jun 05, 2019 at 10:28:14AM +0300, Andrew Rybchenko wrote: > Hi, > > On 6/5/19 4:41 AM, Tiwei Bie wrote: > > Hi, > > Thanks for the patch! > > > More will follow. At least Tx checksum offload is broken when used together > with VLAN insertion since the later prepend to mbuf, but

Re: [dpdk-dev] [PATCH v2] net/virtio: add Tx preparation

Hi, On 6/5/19 4:41 AM, Tiwei Bie wrote: Hi, Thanks for the patch! More will follow. At least Tx checksum offload is broken when used together with VLAN insertion since the later prepend to mbuf, but do nothing with l2_len/outer_l2_len. We'll send a patch to move rte_vlan_insert() to Tx prepar

Re: [dpdk-dev] [PATCH v2] net/virtio: add Tx preparation

Hi, Thanks for the patch! On Mon, Jun 03, 2019 at 07:50:05PM +0100, Andrew Rybchenko wrote: [...] > uint16_t > +virtio_xmit_pkts_prepare(void *tx_queue __rte_unused, struct rte_mbuf > **tx_pkts, > + uint16_t nb_pkts) > +{ > + uint16_t nb_tx; > + int error; > + > +