Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics

2019-06-25 Thread Pattan, Reshma
> -Original Message- > From: Pattan, Reshma > Sent: Tuesday, June 25, 2019 9:39 AM > To: Chautru, Nicolas ; Thomas Monjalon > > Cc: dev@dpdk.org; Laatz, Kevin > Subject: RE: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global > metrics > >

Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics

2019-06-25 Thread Pattan, Reshma
> -Original Message- > From: Chautru, Nicolas > Sent: Monday, June 24, 2019 6:37 PM > To: Thomas Monjalon ; Pattan, Reshma > > Cc: dev@dpdk.org; Laatz, Kevin > Subject: RE: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global > metrics > >

Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics

2019-06-24 Thread Chautru, Nicolas
@dpdk.org; Laatz, Kevin Subject: Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics 18/06/2019 15:49, Reshma Pattan: > telemetry has support for fetching port based stats from metrics > library. > > Metrics library also has global stats which are no

Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics

2019-06-24 Thread Thomas Monjalon
18/06/2019 15:49, Reshma Pattan: > telemetry has support for fetching port based stats > from metrics library. > > Metrics library also has global stats which are > not fetched by telemetry, so extend telemetry to > fetch the global metrics. > > Signed-off-by: Reshma Pattan > Acked-by: Kevin Laa

Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics

2019-06-20 Thread Laatz, Kevin
> Hi Reshma, Kevin, > > Not related to this patch, but when telemetry library enabled, it is causing > some warnings [1] with gcc9 > > The [-Waddress-of-packed-member] warnings already disable for gcc, but > you need following update to "lib/librte_telemetry/Makefile": > -CFLAGS += -I$(SRCDIR)

Re: [dpdk-dev] [PATCH v2] lib/telemetry: add support to fetch global metrics

2019-06-19 Thread Ferruh Yigit
On 6/18/2019 2:49 PM, Reshma Pattan wrote: > telemetry has support for fetching port based stats > from metrics library. > > Metrics library also has global stats which are > not fetched by telemetry, so extend telemetry to > fetch the global metrics. > > Signed-off-by: Reshma Pattan > Acked-by: