Re: [dpdk-dev] [PATCH v2] cmdline: avoid name clash with Windows system types

2020-09-17 Thread Olivier Matz
Hi, On Thu, Sep 03, 2020 at 10:40:31AM +0100, Bruce Richardson wrote: > On Thu, Sep 03, 2020 at 12:30:56PM +0300, Dmitry Kozlyuk wrote: > > On Thu, 3 Sep 2020 10:20:52 +0100, Bruce Richardson wrote: > > > On Wed, Sep 02, 2020 at 09:38:05PM +0300, Dmitry Kozlyuk wrote: > > > > cmdline_numtype membe

Re: [dpdk-dev] [PATCH v2] cmdline: avoid name clash with Windows system types

2020-09-03 Thread Bruce Richardson
On Thu, Sep 03, 2020 at 12:30:56PM +0300, Dmitry Kozlyuk wrote: > On Thu, 3 Sep 2020 10:20:52 +0100, Bruce Richardson wrote: > > On Wed, Sep 02, 2020 at 09:38:05PM +0300, Dmitry Kozlyuk wrote: > > > cmdline_numtype member names clash with Windows system identifiers. > > > Add CMDLINE_ prefix to cmd

Re: [dpdk-dev] [PATCH v2] cmdline: avoid name clash with Windows system types

2020-09-03 Thread Dmitry Kozlyuk
On Thu, 3 Sep 2020 10:20:52 +0100, Bruce Richardson wrote: > On Wed, Sep 02, 2020 at 09:38:05PM +0300, Dmitry Kozlyuk wrote: > > cmdline_numtype member names clash with Windows system identifiers. > > Add CMDLINE_ prefix to cmdline constants to avoid this and possible > > future conflicts. > > > >

Re: [dpdk-dev] [PATCH v2] cmdline: avoid name clash with Windows system types

2020-09-03 Thread Bruce Richardson
On Wed, Sep 02, 2020 at 09:38:05PM +0300, Dmitry Kozlyuk wrote: > cmdline_numtype member names clash with Windows system identifiers. > Add CMDLINE_ prefix to cmdline constants to avoid this and possible > future conflicts. > > Signed-off-by: Dmitry Kozlyuk > Suggested-by: Ranjit Menon > --- Is