Re: [dpdk-dev] [PATCH v12 1/6] lib: add information metrics library

2017-03-28 Thread Remy Horton
On 28/03/2017 15:14, Pattan, Reshma wrote: [..] + +include $(RTE_SDK)/mk/rte.vars.mk + +# library name +LIB = librte_metrics.a + +CFLAGS += $(WERROR_FLAGS) -I$(SRCDIR) How about adding -O3 to flags? Off the top of my mind, I think such flags are added to CFLAGS separately. I think optimisat

Re: [dpdk-dev] [PATCH v12 1/6] lib: add information metrics library

2017-03-28 Thread Pattan, Reshma
Hi, Few nits below. > -Original Message- > From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Remy Horton > Sent: Monday, March 27, 2017 9:22 PM > To: dev@dpdk.org > Cc: Thomas Monjalon > Subject: [dpdk-dev] [PATCH v12 1/6] lib: add information metrics library > > diff --git a/doc/gui