Re: [dpdk-dev] [PATCH v10 2/3] lib/gro: add TCP/IPv4 GRO support

2017-07-04 Thread Hu, Jiayu
Hi Yuanhan, > -Original Message- > From: Yuanhan Liu [mailto:y...@fridaylinux.org] > Sent: Tuesday, July 4, 2017 5:03 PM > To: Hu, Jiayu > Cc: dev@dpdk.org; Ananyev, Konstantin ; > step...@networkplumber.org; Tan, Jianfeng ; Wu, > Jingjing ; Yao, Lei A ; Bie, > Tiwei > Subject: Re: [PATC

Re: [dpdk-dev] [PATCH v10 2/3] lib/gro: add TCP/IPv4 GRO support

2017-07-04 Thread Yuanhan Liu
Again, just some quick comments after a glimpse. On Sat, Jul 01, 2017 at 07:08:42PM +0800, Jiayu Hu wrote: > + for (i = 0; i < nb_pkts; i++) { > + if (RTE_ETH_IS_IPV4_HDR(pkts[i]->packet_type) && > + (pkts[i]->packet_type & RTE_PTYPE_L4_TCP)) { > +

Re: [dpdk-dev] [PATCH v10 2/3] lib/gro: add TCP/IPv4 GRO support

2017-07-02 Thread Hu, Jiayu
Hi Jianfeng, > -Original Message- > From: Tan, Jianfeng > Sent: Sunday, July 2, 2017 6:20 PM > To: Hu, Jiayu ; dev@dpdk.org > Cc: Ananyev, Konstantin ; > step...@networkplumber.org; y...@fridaylinux.org; Wu, Jingjing > ; Yao, Lei A ; Bie, Tiwei > > Subject: Re: [PATCH v10 2/3] lib/gro: ad

Re: [dpdk-dev] [PATCH v10 2/3] lib/gro: add TCP/IPv4 GRO support

2017-07-02 Thread Tan, Jianfeng
On 7/1/2017 7:08 PM, Jiayu Hu wrote: In this patch, we introduce five APIs to support TCP/IPv4 GRO. - gro_tcp4_tbl_create: create a TCP/IPv4 reassembly table, which is used to merge packets. - gro_tcp4_tbl_destroy: free memory space of a TCP/IPv4 reassembly table. - gro_tcp4_tbl_timeout_fl