Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-24 Thread Maxime Coquelin
On 6/24/20 10:38 AM, Matan Azrad wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Wednesday, June 24, 2020 10:22 AM >> To: Matan Azrad ; Xiao Wang >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition >> >> Good morning Matan,

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-24 Thread Matan Azrad
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 24, 2020 10:22 AM > To: Matan Azrad ; Xiao Wang > > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition > > Good morning Matan, > > On 6/24/20 7:54 AM, Matan Azrad wrote: > > Ho Maxi

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-24 Thread Maxime Coquelin
Good morning Matan, On 6/24/20 7:54 AM, Matan Azrad wrote: > Ho Maxime > > Good morning > > From: Maxime Coquelin: >> On 6/23/20 4:52 PM, Matan Azrad wrote: >>> >>> -Original Message- From: Maxime Coquelin Sent: Tuesday, June 23, 2020 4:56 PM To: Matan Azrad ; Xiao W

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Matan Azrad
Ho Maxime Good morning From: Maxime Coquelin: > On 6/23/20 4:52 PM, Matan Azrad wrote: > > > > > >> -Original Message- > >> From: Maxime Coquelin > >> Sent: Tuesday, June 23, 2020 4:56 PM > >> To: Matan Azrad ; Xiao Wang > >> > >> Cc: dev@dpdk.org > >> Subject: Re: [PATCH v1 3/4] vhost:

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Maxime Coquelin
On 6/23/20 4:52 PM, Matan Azrad wrote: > > >> -Original Message- >> From: Maxime Coquelin >> Sent: Tuesday, June 23, 2020 4:56 PM >> To: Matan Azrad ; Xiao Wang >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition >> >> Hi Matan, >> >> On 6/23/

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Matan Azrad
> -Original Message- > From: Maxime Coquelin > Sent: Tuesday, June 23, 2020 4:56 PM > To: Matan Azrad ; Xiao Wang > > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition > > Hi Matan, > > On 6/23/20 1:53 PM, Matan Azrad wrote: > > > > > > From: Maxime

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Maxime Coquelin
On 6/23/20 3:55 PM, Maxime Coquelin wrote: > Hi Matan, > > On 6/23/20 1:53 PM, Matan Azrad wrote: >> >> >> From: Maxime Coquelin: >>> On 6/23/20 11:02 AM, Matan Azrad wrote: From: Maxime Coquelin: > On 6/22/20 5:51 PM, Matan Azrad wrote: >> >> >> From: Maxime Coqu

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Maxime Coquelin
Hi Matan, On 6/23/20 1:53 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> On 6/23/20 11:02 AM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin: On 6/22/20 5:51 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> On 6/22/20 3:43 PM, Matan Azrad wrote: >>> >

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Matan Azrad
From: Maxime Coquelin: > On 6/23/20 11:02 AM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin: > >> On 6/22/20 5:51 PM, Matan Azrad wrote: > >>> > >>> > >>> From: Maxime Coquelin: > On 6/22/20 3:43 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin: > >> Sent: Mond

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Maxime Coquelin
On 6/23/20 11:02 AM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> On 6/22/20 5:51 PM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin: On 6/22/20 3:43 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> Sent: Monday, June 22, 2020 3:33 PM >> To: Matan Azr

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-23 Thread Matan Azrad
From: Maxime Coquelin: > On 6/22/20 5:51 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin: > >> On 6/22/20 3:43 PM, Matan Azrad wrote: > >>> > >>> > >>> From: Maxime Coquelin: > Sent: Monday, June 22, 2020 3:33 PM > To: Matan Azrad ; Xiao Wang > > Cc: dev@dpdk.org > >

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Maxime Coquelin
On 6/22/20 5:51 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> On 6/22/20 3:43 PM, Matan Azrad wrote: >>> >>> >>> From: Maxime Coquelin: Sent: Monday, June 22, 2020 3:33 PM To: Matan Azrad ; Xiao Wang Cc: dev@dpdk.org Subject: Re: [PATCH v1 3/4] vhost: improve

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Matan Azrad
From: Maxime Coquelin: > On 6/22/20 3:43 PM, Matan Azrad wrote: > > > > > > From: Maxime Coquelin: > >> Sent: Monday, June 22, 2020 3:33 PM > >> To: Matan Azrad ; Xiao Wang > >> > >> Cc: dev@dpdk.org > >> Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition > >> > >> > >> > >> On 6

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Maxime Coquelin
On 6/22/20 3:43 PM, Matan Azrad wrote: > > > From: Maxime Coquelin: >> Sent: Monday, June 22, 2020 3:33 PM >> To: Matan Azrad ; Xiao Wang >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition >> >> >> >> On 6/22/20 12:06 PM, Matan Azrad wrote: >>> >>> Hi

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Matan Azrad
From: Maxime Coquelin: > Sent: Monday, June 22, 2020 3:33 PM > To: Matan Azrad ; Xiao Wang > > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition > > > > On 6/22/20 12:06 PM, Matan Azrad wrote: > > > > Hi Maxime > > > > From: Maxime Coquelin > >> Sent: Mond

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Maxime Coquelin
On 6/22/20 12:06 PM, Matan Azrad wrote: > > Hi Maxime > > From: Maxime Coquelin >> Sent: Monday, June 22, 2020 11:56 AM >> To: Matan Azrad ; Xiao Wang >> >> Cc: dev@dpdk.org >> Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition >> >> >> >> On 6/22/20 10:41 AM, Matan Azrad wro

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Matan Azrad
Hi Maxime From: Maxime Coquelin > Sent: Monday, June 22, 2020 11:56 AM > To: Matan Azrad ; Xiao Wang > > Cc: dev@dpdk.org > Subject: Re: [PATCH v1 3/4] vhost: improve device ready definition > > > > On 6/22/20 10:41 AM, Matan Azrad wrote: > >> The issue is if you only check ready state only

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Maxime Coquelin
On 6/22/20 10:41 AM, Matan Azrad wrote: >> The issue is if you only check ready state only before and after the message >> affecting the ring is handled, it can be ready at both stages, while the >> rings >> have changed and state change callback should have been called. > But in this version I

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Matan Azrad
From: Maxime Coquelin > Hi, > > On 6/21/20 8:20 AM, Matan Azrad wrote: > > Hi Maxime > > > > From: Maxime Coquelin: > >> Hi Matan, > >> > >> On 6/19/20 3:11 PM, Matan Azrad wrote: > >>> Hi Maxime > >>> > >>> Thanks for the fast review. > >>> This is first version, let's review it carefully to be

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-22 Thread Maxime Coquelin
Hi, On 6/21/20 8:20 AM, Matan Azrad wrote: > Hi Maxime > > From: Maxime Coquelin: >> Hi Matan, >> >> On 6/19/20 3:11 PM, Matan Azrad wrote: >>> Hi Maxime >>> >>> Thanks for the fast review. >>> This is first version, let's review it carefully to be sure it is correct. >>> @Xiao Wang, it will be g

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-20 Thread Matan Azrad
Hi Maxime From: Maxime Coquelin: > Hi Matan, > > On 6/19/20 3:11 PM, Matan Azrad wrote: > > Hi Maxime > > > > Thanks for the fast review. > > This is first version, let's review it carefully to be sure it is correct. > > @Xiao Wang, it will be good to hear your idea too. > > We also need to under

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-19 Thread Maxime Coquelin
Hi Matan, On 6/19/20 3:11 PM, Matan Azrad wrote: > Hi Maxime > > Thanks for the fast review. > This is first version, let's review it carefully to be sure it is correct. > @Xiao Wang, it will be good to hear your idea too. > We also need to understand the effect on IFC driver/device... > Just to

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-19 Thread Matan Azrad
Hi Maxime Thanks for the fast review. This is first version, let's review it carefully to be sure it is correct. @Xiao Wang, it will be good to hear your idea too. We also need to understand the effect on IFC driver/device... Just to update that I checked this code with the mlx5 adjustments and I

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-19 Thread Maxime Coquelin
Hi Matan, On 6/19/20 9:41 AM, Maxime Coquelin wrote: > > > On 6/18/20 6:28 PM, Matan Azrad wrote: >> Some guest drivers may not configure disabled virtio queues. >> >> In this case, the vhost management never triggers the vDPA device >> configuration because it waits to the device to be ready. >

Re: [dpdk-dev] [PATCH v1 3/4] vhost: improve device ready definition

2020-06-19 Thread Maxime Coquelin
On 6/18/20 6:28 PM, Matan Azrad wrote: > Some guest drivers may not configure disabled virtio queues. > > In this case, the vhost management never triggers the vDPA device > configuration because it waits to the device to be ready. This is not vDPA-only, even with SW datapath the application's