Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-06-25 Thread Ferruh Yigit
On 6/8/2021 1:39 PM, Andrew Rybchenko wrote: > On 6/8/21 3:29 PM, Olivier Matz wrote: >> Hi Ferruh, Andrew, >> >> On Tue, Jun 08, 2021 at 01:23:33PM +0300, Andrew Rybchenko wrote: >>> On 4/30/21 6:42 PM, Ferruh Yigit wrote: On 4/27/2021 2:57 PM, Olivier Matz wrote: > Since commit d5df2ae04

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-06-08 Thread Andrew Rybchenko
On 6/8/21 3:29 PM, Olivier Matz wrote: > Hi Ferruh, Andrew, > > On Tue, Jun 08, 2021 at 01:23:33PM +0300, Andrew Rybchenko wrote: >> On 4/30/21 6:42 PM, Ferruh Yigit wrote: >>> On 4/27/2021 2:57 PM, Olivier Matz wrote: Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP chec

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-06-08 Thread Olivier Matz
Hi Ferruh, Andrew, On Tue, Jun 08, 2021 at 01:23:33PM +0300, Andrew Rybchenko wrote: > On 4/30/21 6:42 PM, Ferruh Yigit wrote: > > On 4/27/2021 2:57 PM, Olivier Matz wrote: > >> Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP > >> checksum 0"), the functions rte_ipv4_udptcp_cksum(

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-06-08 Thread Andrew Rybchenko
On 4/30/21 6:42 PM, Ferruh Yigit wrote: > On 4/27/2021 2:57 PM, Olivier Matz wrote: >> Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP >> checksum 0"), the functions rte_ipv4_udptcp_cksum() and >> rte_ipv6_udptcp_cksum() can return either 0x or 0x when used to >> verify a p

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-04-30 Thread Ferruh Yigit
On 4/27/2021 2:57 PM, Olivier Matz wrote: > Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP > checksum 0"), the functions rte_ipv4_udptcp_cksum() and > rte_ipv6_udptcp_cksum() can return either 0x or 0x when used to > verify a packet containing a valid checksum. > > Since

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-04-28 Thread Morten Brørup
> From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Olivier Matz > Sent: Wednesday, April 28, 2021 2:22 PM > > Hi Morten, > > Thank you for the review. > > <...> > > On Tue, Apr 27, 2021 at 05:07:04PM +0200, Morten Brørup wrote: > > > +static inline uint16_t > > > +rte_ipv4_udptcp_cksum(cons

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-04-28 Thread Olivier Matz
Hi Morten, Thank you for the review. <...> On Tue, Apr 27, 2021 at 05:07:04PM +0200, Morten Brørup wrote: > > +static inline uint16_t > > +rte_ipv4_udptcp_cksum(const struct rte_ipv4_hdr *ipv4_hdr, const void > > *l4_hdr) > > +{ > > + uint16_t cksum = __rte_ipv4_udptcp_cksum(ipv4_hdr, l4_hdr);

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-04-27 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Tuesday, April 27, 2021 3:58 PM > > Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP > checksum 0"), the functions rte_ipv4_udptcp_cksum() and > rte_ipv6_udptcp_cksum() can return either 0x or 0x when used to > ve

Re: [dpdk-dev] [PATCH 3/4] net: introduce functions to verify L4 checksums

2021-04-27 Thread Morten Brørup
> From: Olivier Matz [mailto:olivier.m...@6wind.com] > Sent: Tuesday, April 27, 2021 3:58 PM > > Since commit d5df2ae0428a ("net: fix unneeded replacement of TCP > checksum 0"), the functions rte_ipv4_udptcp_cksum() and > rte_ipv6_udptcp_cksum() can return either 0x or 0x when used to > ve