Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-10 Thread Tiwei Bie
On Thu, Oct 10, 2019 at 11:27:53AM +0300, Andrew Rybchenko wrote: > On 10/10/19 11:23 AM, David Marchand wrote: > > On Thu, Oct 10, 2019 at 10:14 AM Andrew Rybchenko > > wrote: > > > On 10/10/19 10:42 AM, Thomas Monjalon wrote: > > > > 09/10/2019 13:24, Andrew Rybchenko: > > > > > On 10/9/19 1:41

Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-10 Thread Andrew Rybchenko
On 10/10/19 11:23 AM, David Marchand wrote: On Thu, Oct 10, 2019 at 10:14 AM Andrew Rybchenko wrote: On 10/10/19 10:42 AM, Thomas Monjalon wrote: 09/10/2019 13:24, Andrew Rybchenko: On 10/9/19 1:41 PM, Tiwei Bie wrote: My understanding is that, setting mq_mode to ETH_MQ_RX_NONE means no meth

Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-10 Thread David Marchand
On Thu, Oct 10, 2019 at 10:14 AM Andrew Rybchenko wrote: > > On 10/10/19 10:42 AM, Thomas Monjalon wrote: > > 09/10/2019 13:24, Andrew Rybchenko: > >> On 10/9/19 1:41 PM, Tiwei Bie wrote: > >>> My understanding is that, setting mq_mode to ETH_MQ_RX_NONE means > >>> no method is enforced on how to

Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-10 Thread Andrew Rybchenko
On 10/10/19 10:42 AM, Thomas Monjalon wrote: 09/10/2019 13:24, Andrew Rybchenko: On 10/9/19 1:41 PM, Tiwei Bie wrote: On Wed, Oct 09, 2019 at 12:00:28PM +0300, Andrew Rybchenko wrote: And one more thought... It looks like if more than one Rx queue is configured, mq_mode must be ETH_MQ_RX_RSS a

Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-10 Thread Thomas Monjalon
09/10/2019 13:24, Andrew Rybchenko: > On 10/9/19 1:41 PM, Tiwei Bie wrote: > > On Wed, Oct 09, 2019 at 12:00:28PM +0300, Andrew Rybchenko wrote: > >> And one more thought... > >> It looks like if more than one Rx queue is configured, mq_mode must > >> be ETH_MQ_RX_RSS and must not be ETH_MQ_RX_NONE

Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-09 Thread Andrew Rybchenko
@Thomas, @Ferruh, please see small question below. On 10/9/19 1:41 PM, Tiwei Bie wrote: On Wed, Oct 09, 2019 at 12:00:28PM +0300, Andrew Rybchenko wrote: On 10/9/19 11:43 AM, Tiwei Bie wrote: On Wed, Oct 09, 2019 at 11:04:38AM +0300, Andrew Rybchenko wrote: On 10/8/19 8:46 AM, Tiwei Bie wrote

Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-09 Thread Tiwei Bie
On Wed, Oct 09, 2019 at 12:00:28PM +0300, Andrew Rybchenko wrote: > On 10/9/19 11:43 AM, Tiwei Bie wrote: > > On Wed, Oct 09, 2019 at 11:04:38AM +0300, Andrew Rybchenko wrote: > > > On 10/8/19 8:46 AM, Tiwei Bie wrote: > > > > On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote: > > >

Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-09 Thread Andrew Rybchenko
On 10/9/19 11:43 AM, Tiwei Bie wrote: On Wed, Oct 09, 2019 at 11:04:38AM +0300, Andrew Rybchenko wrote: On 10/8/19 8:46 AM, Tiwei Bie wrote: On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote: From: Dilshod Urazov This driver supports none of DCB, RSS or VMDQ modes, therefore m

Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-09 Thread Tiwei Bie
On Wed, Oct 09, 2019 at 11:04:38AM +0300, Andrew Rybchenko wrote: > On 10/8/19 8:46 AM, Tiwei Bie wrote: > > On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote: > > > From: Dilshod Urazov > > > > > > This driver supports none of DCB, RSS or VMDQ modes, > > > therefore must check and

Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-09 Thread Andrew Rybchenko
On 10/8/19 8:46 AM, Tiwei Bie wrote: On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote: From: Dilshod Urazov This driver supports none of DCB, RSS or VMDQ modes, therefore must check and return error if configured incorrectly. Fixes: c1f86306a026 ("virtio: add new driver") Cc:

Re: [dpdk-dev] [PATCH 3/3] net/virtio: reject unsupported Rx multi queue modes

2019-10-07 Thread Tiwei Bie
On Tue, Oct 01, 2019 at 04:44:31PM +0100, Andrew Rybchenko wrote: > From: Dilshod Urazov > > This driver supports none of DCB, RSS or VMDQ modes, > therefore must check and return error if configured incorrectly. > > Fixes: c1f86306a026 ("virtio: add new driver") > Cc: sta...@dpdk.org > > Signe