Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-10 Thread Bruce Richardson
On Wed, Apr 10, 2019 at 02:24:56PM +0100, Bruce Richardson wrote: > On Wed, Apr 10, 2019 at 09:10:25AM -0400, Aaron Conole wrote: > > > > Okay - I'll look at this part more. I think I went down the path of > > explicitly setting these because the comments didn't match with what was > > occuring (

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-10 Thread Bruce Richardson
On Wed, Apr 10, 2019 at 09:10:25AM -0400, Aaron Conole wrote: > "Ananyev, Konstantin" writes: > > >> > >> > > Hi Aaron, > >> > > > >> > >> > >> > >> This makes the tests pass, and also ensures that on platforms where > >> > >> the > >> > >> testing is supported, we can properly test the impleme

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-10 Thread Aaron Conole
"Ananyev, Konstantin" writes: >> >> > > Hi Aaron, >> > > >> > >> >> > >> This makes the tests pass, and also ensures that on platforms where the >> > >> testing is supported, we can properly test the implementation specific >> > >> code. One edge case is when we run on x86_64 systems that don't

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-10 Thread Bruce Richardson
On Tue, Apr 09, 2019 at 07:29:09PM +0100, Ananyev, Konstantin wrote: > > > > > > > > > Hi Aaron, > > > > > > > > > >> > > > > >> This makes the tests pass, and also ensures that on platforms where > > > > >> the testing is supported, we can properly test the implementation > > > > >> specific code

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-10 Thread Richardson, Bruce
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, April 9, 2019 6:05 PM > To: Ananyev, Konstantin ; Aaron Conole > > Cc: dev@dpdk.org; Jerin Jacob ; Gavin Hu > ; Richardson, Bruce ; > Michael Santana > Subject: RE: [PATCH 3/3] acl: adjust the tests > > > > > > > > >

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-09 Thread Ananyev, Konstantin
> > > > > > Hi Aaron, > > > > > > > >> > > > >> This makes the tests pass, and also ensures that on platforms where > > > >> the testing is supported, we can properly test the implementation > > > >> specific code. One edge case is when we run on x86_64 systems that > > > >> don't support AVX2,

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-09 Thread Richardson, Bruce
> -Original Message- > From: Ananyev, Konstantin > Sent: Tuesday, April 9, 2019 5:03 PM > To: Aaron Conole > Cc: dev@dpdk.org; Jerin Jacob ; Gavin Hu > ; Richardson, Bruce ; > Michael Santana > Subject: RE: [PATCH 3/3] acl: adjust the tests > > > > > Hi Aaron, > > > > > >> > > >> Thi

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-09 Thread Ananyev, Konstantin
> > > > Hi Aaron, > > > > > >> > > >> This makes the tests pass, and also ensures that on platforms where the > > >> testing is supported, we can properly test the implementation specific > > >> code. One edge case is when we run on x86_64 systems that don't support > > >> AVX2, but where the

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-09 Thread Ananyev, Konstantin
> > Hi Aaron, > > > >> > >> This makes the tests pass, and also ensures that on platforms where the > >> testing is supported, we can properly test the implementation specific > >> code. One edge case is when we run on x86_64 systems that don't support > >> AVX2, but where the compiler can gener

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-09 Thread Aaron Conole
"Ananyev, Konstantin" writes: > Hi Aaron, > >> >> This makes the tests pass, and also ensures that on platforms where the >> testing is supported, we can properly test the implementation specific >> code. One edge case is when we run on x86_64 systems that don't support >> AVX2, but where the c

Re: [dpdk-dev] [PATCH 3/3] acl: adjust the tests

2019-04-09 Thread Ananyev, Konstantin
Hi Aaron, > > This makes the tests pass, and also ensures that on platforms where the > testing is supported, we can properly test the implementation specific > code. One edge case is when we run on x86_64 systems that don't support > AVX2, but where the compiler can generate such instructions.