Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-09 Thread Wang, Ying A
> -Original Message- > From: Ye, Xiaolong > Sent: Monday, September 9, 2019 5:54 PM > To: Wang, Ying A > Cc: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org; Zhao1, Wei > Subject: Re: [PATCH 2/4] net/ice: rework for generic flow enabling > > On 09/09, Wang, Ying A wrote: > >> >+ice_unregi

Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-09 Thread Ye Xiaolong
On 09/09, Wang, Ying A wrote: >> >+ice_unregister_parser(struct ice_flow_parser *parser, >> >+ struct ice_adapter *ad) >> >+{ >> >+ struct ice_pf *pf = &ad->pf; >> >+ struct ice_parser_list *list; >> >+ struct ice_flow_parser *p_parser; >> >+ void *temp; >> >+ >> >+ switch (pars

Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-09 Thread Ye Xiaolong
On 09/09, Wang, Ying A wrote: [snip] >> >+ if (ad->devargs.pipeline_mode_support) { >> >+ if (0 == attr->priority) >> >+ ice_pipeline_stage = >> >+ ICE_FLOW_CLASSIFY_STAGE_PERMISSION; >> >+ else >> >+ ice_pipeline

Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-08 Thread Wang, Ying A
Hi, Xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Sunday, September 8, 2019 11:56 PM > To: Wang, Ying A > Cc: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org; Zhao1, Wei > Subject: Re: [PATCH 2/4] net/ice: rework for generic flow enabling > > On 09/04, Ying Wang wrote: > >The p

Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-08 Thread Wang, Ying A
Hi, Xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Saturday, September 7, 2019 12:13 AM > To: Wang, Ying A > Cc: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org; Zhao1, Wei > Subject: Re: [PATCH 2/4] net/ice: rework for generic flow enabling > > On 09/04, Ying Wang wrote: > >The

Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-08 Thread Ye Xiaolong
On 09/04, Ying Wang wrote: >The patch reworks the generic flow API (rte_flow) implementation. >It introduces an abstract layer which provides a unified interface >for low-level filter engine (switch, fdir, hash) to register supported >patterns and actions and implement flow validate/create/destroy/

Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-06 Thread Ye Xiaolong
On 09/04, Ying Wang wrote: >The patch reworks the generic flow API (rte_flow) implementation. >It introduces an abstract layer which provides a unified interface >for low-level filter engine (switch, fdir, hash) to register supported >patterns and actions and implement flow validate/create/destroy/

Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-05 Thread Ye Xiaolong
On 09/05, Wang, Ying A wrote: > >For the previous indentation is not tab-aligned, I will add a separate code >cleanup patch for these changes. > >> >> > { >> >uint32_t cpy_count = 0; >> >const struct rte_flow_item *pb = pattern, *pe = pattern; @@ -124,7 >> >+285,6 @@ ice_pattern_skip_void

Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-05 Thread Wang, Ying A
Hi, Xiaolong > -Original Message- > From: Ye, Xiaolong > Sent: Wednesday, September 4, 2019 10:45 PM > To: Wang, Ying A > Cc: Zhang, Qi Z ; Yang, Qiming > ; dev@dpdk.org; Zhao1, Wei > Subject: Re: [PATCH 2/4] net/ice: rework for generic flow enabling > > On 09/04, Ying Wang wrote: > >Th

Re: [dpdk-dev] [PATCH 2/4] net/ice: rework for generic flow enabling

2019-09-04 Thread Ye Xiaolong
On 09/04, Ying Wang wrote: >The patch reworks the generic flow API (rte_flow) implementation. >It introduces an abstract layer which provides a unified interface >for low-level filter engine (switch, fdir, hash) to register supported >patterns and actions and implement flow validate/create/destroy/