Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-09-30 Thread Maxime Coquelin
On 6/19/19 8:13 AM, Noa Ezra wrote: > Rx mergeable buffers is a virtio feature that allows chaining of > multiple virtio descriptors to handle large packet size. > This behavior is supported and enabled by default, however in case > the user knows that rx mergeable buffers are not needed, he can

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-08-30 Thread Maxime Coquelin
On 6/27/19 7:04 AM, Matan Azrad wrote: > > > From: Maxime Coquelin >> For functional reasons, I agree. So I that's why I agree with your >> tso patch as the application has to support it, but that's not the >> case of the mergeable buffers features. > > Performance reasons

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-26 Thread Matan Azrad
From: Maxime Coquelin > For functional reasons, I agree. So I that's why I agree with your > tso patch as the application has to support it, but that's not the > case of the mergeable buffers features. > >>> > >>> Performance reasons are not good enough? > >> > >> No, that's not w

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-26 Thread Maxime Coquelin
On 6/26/19 3:24 PM, Matan Azrad wrote: -Original Message- From: Maxime Coquelin Sent: Wednesday, June 26, 2019 3:06 PM To: Matan Azrad ; Noa Ezra Cc: dev@dpdk.org; Tiwei Bie Subject: Re: [PATCH 2/2] net/vhost: support mrg-rxbuf disabling On 6/26/19 1:18 PM, Matan Azrad wrote:

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-26 Thread Matan Azrad
> -Original Message- > From: Maxime Coquelin > Sent: Wednesday, June 26, 2019 3:06 PM > To: Matan Azrad ; Noa Ezra > Cc: dev@dpdk.org; Tiwei Bie > Subject: Re: [PATCH 2/2] net/vhost: support mrg-rxbuf disabling > > > > On 6/26/19 1:18 PM, Matan Azrad wrote: > > > > > > From: Maxime

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-26 Thread Maxime Coquelin
On 6/26/19 1:18 PM, Matan Azrad wrote: From: Maxime Coquelin On 6/26/19 9:50 AM, Matan Azrad wrote: Hi Maxim Any response here? Besides that, Regarding the TSO and this patch: I think we shouldn't be so strict to not take them for this version: 1. The later time was a technical issue wi

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-26 Thread Matan Azrad
From: Maxime Coquelin > On 6/26/19 9:50 AM, Matan Azrad wrote: > > Hi Maxim > > > > Any response here? > > > > Besides that, > > > > Regarding the TSO and this patch: > > I think we shouldn't be so strict to not take them for this version: > > 1. The later time was a technical issue with the mail

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-26 Thread Maxime Coquelin
On 6/26/19 9:50 AM, Matan Azrad wrote: Hi Maxim Any response here? Besides that, Regarding the TSO and this patch: I think we shouldn't be so strict to not take them for this version: 1. The later time was a technical issue with the mailer - a mistake. 2. The patches don't change any defaul

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-26 Thread Matan Azrad
Hi Maxim Any response here? Besides that, Regarding the TSO and this patch: I think we shouldn't be so strict to not take them for this version: 1. The later time was a technical issue with the mailer - a mistake. 2. The patches don't change any default and makes sense - will not hurt anyone.

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-20 Thread Matan Azrad
From: Maxime Coquelin > Sent: Thursday, June 20, 2019 10:19 AM > To: Matan Azrad ; Noa Ezra > Cc: dev@dpdk.org > Subject: Re: [PATCH 2/2] net/vhost: support mrg-rxbuf disabling > > > > On 6/20/19 8:52 AM, Matan Azrad wrote: > > Hi all > > > >> -Original Message- > >> From: Noa Ezra >

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-20 Thread Maxime Coquelin
On 6/20/19 7:57 AM, Noa Ezra wrote: Hi Maxime, Thanks for your comment, please see below. -Original Message- From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] Sent: Wednesday, June 19, 2019 12:10 PM To: Noa Ezra Cc: Matan Azrad ; dev@dpdk.org Subject: Re: [PATCH 2/2] net/vho

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-20 Thread Maxime Coquelin
On 6/20/19 8:52 AM, Matan Azrad wrote: Hi all -Original Message- From: Noa Ezra Sent: Thursday, June 20, 2019 8:58 AM To: Maxime Coquelin Cc: Matan Azrad ; dev@dpdk.org Subject: RE: [PATCH 2/2] net/vhost: support mrg-rxbuf disabling Hi Maxime, Thanks for your comment, please see be

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-19 Thread Matan Azrad
Hi all > -Original Message- > From: Noa Ezra > Sent: Thursday, June 20, 2019 8:58 AM > To: Maxime Coquelin > Cc: Matan Azrad ; dev@dpdk.org > Subject: RE: [PATCH 2/2] net/vhost: support mrg-rxbuf disabling > > Hi Maxime, > Thanks for your comment, please see below. > > > -Original M

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-19 Thread Noa Ezra
Hi Maxime, Thanks for your comment, please see below. > -Original Message- > From: Maxime Coquelin [mailto:maxime.coque...@redhat.com] > Sent: Wednesday, June 19, 2019 12:10 PM > To: Noa Ezra > Cc: Matan Azrad ; dev@dpdk.org > Subject: Re: [PATCH 2/2] net/vhost: support mrg-rxbuf disablin

Re: [dpdk-dev] [PATCH 2/2] net/vhost: support mrg-rxbuf disabling

2019-06-19 Thread Maxime Coquelin
Hi Noa, On 6/19/19 8:13 AM, Noa Ezra wrote: Rx mergeable buffers is a virtio feature that allows chaining of multiple virtio descriptors to handle large packet size. This behavior is supported and enabled by default, however in case the user knows that rx mergeable buffers are not needed, he can