Re: [dpdk-dev] [PATCH 2/2] net/mlx4: refactor RSS conversion functions

2018-05-21 Thread Adrien Mazarguil
On Mon, May 21, 2018 at 10:59:36AM +, Shahaf Shuler wrote: > Hi Adrien, > > Please help me walkthrough this logic. Something doesn't end up correctly. > > Friday, May 18, 2018 12:49 PM, Adrien Mazarguil: > > Cc: Shahaf Shuler ; dev@dpdk.org > > Subject: Re: [PATCH 2/2] net/mlx4: refactor RSS

Re: [dpdk-dev] [PATCH 2/2] net/mlx4: refactor RSS conversion functions

2018-05-21 Thread Shahaf Shuler
Hi Adrien, Please help me walkthrough this logic. Something doesn't end up correctly. Friday, May 18, 2018 12:49 PM, Adrien Mazarguil: > Cc: Shahaf Shuler ; dev@dpdk.org > Subject: Re: [PATCH 2/2] net/mlx4: refactor RSS conversion functions > > > Signed-off-by: Adrien Mazarguil > > > Cc: Ophir

Re: [dpdk-dev] [PATCH 2/2] net/mlx4: refactor RSS conversion functions

2018-05-18 Thread Adrien Mazarguil
Hi Ophir, On Thu, May 17, 2018 at 05:46:45PM +, Ophir Munk wrote: > Hi Adrien, > I like the idea of having one conversion function from dpdk to verbs and vice > versa. > I have some comments inline regarding the implementation. > > > -Original Message- > > From: Adrien Mazarguil [mai

Re: [dpdk-dev] [PATCH 2/2] net/mlx4: refactor RSS conversion functions

2018-05-17 Thread Ophir Munk
Hi Adrien, I like the idea of having one conversion function from dpdk to verbs and vice versa. I have some comments inline regarding the implementation. > -Original Message- > From: Adrien Mazarguil [mailto:adrien.mazarg...@6wind.com] > Sent: Tuesday, May 15, 2018 6:51 PM > To: Shahaf Sh