Re: [dpdk-dev] [PATCH 2/2] net/ice: disable advanced features in safe mode

2019-03-01 Thread Stillwell Jr, Paul M
Hi Qiming, For some reason I am not seeing patch 1/2 in this series. Can you make sure you sent it or re-send it? Paul -Original Message- From: dev [mailto:dev-boun...@dpdk.org] On Behalf Of Qiming Yang Sent: Friday, March 1, 2019 4:46 AM To: dev@dpdk.org Cc: Yang, Qiming Subject: [dpd

Re: [dpdk-dev] [PATCH 2/2] net/ice: disable advanced features in safe mode

2019-03-01 Thread Stephen Hemminger
On Fri, 1 Mar 2019 20:46:13 +0800 Qiming Yang wrote: > + PMD_INIT_LOG(WARNING, "Initialize in safe mode," > + "some features are disabled.\n"); Don't split a message string, it makes it harder to search. Also, most drivers define PMD_INIT_LOG to always add a newline and do not