Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-20 Thread Medvedkin, Vladimir
Hi, On 20/10/2020 15:22, Thomas Monjalon wrote: 19/10/2020 16:53, David Marchand: On Fri, Oct 16, 2020 at 12:54 AM Honnappa Nagarahalli wrote: IMO, this is not a performance critical path and it is not a difficult solution to store these values in the application. My suggestion is to skip a

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-20 Thread Thomas Monjalon
19/10/2020 16:53, David Marchand: > On Fri, Oct 16, 2020 at 12:54 AM Honnappa Nagarahalli > wrote: > > > > IMO, this is not a performance critical path and it is not a difficult > > > > solution to > > > store these values in the application. My suggestion is to skip adding > > > the API > > > a

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-19 Thread Honnappa Nagarahalli
> > >> > > >> Hi Ruifeng, > > >> > > >> On 15/09/2020 17:02, Bruce Richardson wrote: > > >>> On Mon, Sep 07, 2020 at 04:15:17PM +0800, Ruifeng Wang wrote: > > Fields except tbl24 and tbl8 in rte_lpm structure have no need to > > be exposed to the user. > > Hide the unneeded exposur

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-19 Thread David Marchand
On Fri, Oct 16, 2020 at 12:54 AM Honnappa Nagarahalli wrote: > > > IMO, this is not a performance critical path and it is not a difficult > > > solution to > > store these values in the application. My suggestion is to skip adding the > > API > > and store the values in the application. > > > Vl

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-16 Thread Michel Machado
If the final choice is for not supporting a way to retrieve the config information on the API, we'll look for a place to keep a copy of the parameters in our code. IMO, this is not a performance critical path and it is not a difficult solution to store these values in the application. My

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-16 Thread Kevin Traynor
On 15/10/2020 23:54, Honnappa Nagarahalli wrote: > >> >> Hello, >> >> On 15/10/2020 18:38, Honnappa Nagarahalli wrote: >>> On 10/14/20 7:57 PM, Honnappa Nagarahalli wrote: On 13/10/2020 18:46, Michel Machado wrote: > On 10/13/20 11:41 AM, Medvedkin, Vladimir wrote:

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-15 Thread Michel Machado
On 10/14/20 7:57 PM, Honnappa Nagarahalli wrote: On 13/10/2020 18:46, Michel Machado wrote: On 10/13/20 11:41 AM, Medvedkin, Vladimir wrote: Hi Michel, Could you please describe a condition when LPM gets inconsistent? As I can see if there is no free tbl8 it will return -ENOSPC.     Conside

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-15 Thread Honnappa Nagarahalli
> > Hello, > > On 15/10/2020 18:38, Honnappa Nagarahalli wrote: > > > >> > >> On 10/14/20 7:57 PM, Honnappa Nagarahalli wrote: > >> On 13/10/2020 18:46, Michel Machado wrote: > >>> On 10/13/20 11:41 AM, Medvedkin, Vladimir wrote: > Hi Michel, > > Could you ple

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-15 Thread Medvedkin, Vladimir
Hello, On 15/10/2020 18:38, Honnappa Nagarahalli wrote: On 10/14/20 7:57 PM, Honnappa Nagarahalli wrote: On 13/10/2020 18:46, Michel Machado wrote: On 10/13/20 11:41 AM, Medvedkin, Vladimir wrote: Hi Michel, Could you please describe a condition when LPM gets inconsistent? As I can see if

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-15 Thread Honnappa Nagarahalli
> > On 10/14/20 7:57 PM, Honnappa Nagarahalli wrote: > On 13/10/2020 18:46, Michel Machado wrote: > > On 10/13/20 11:41 AM, Medvedkin, Vladimir wrote: > >> Hi Michel, > >> > >> Could you please describe a condition when LPM gets inconsistent? > >> As I can see if there is

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-14 Thread Honnappa Nagarahalli
27;ve added Qiaobin Fu, another Gatekeeper maintainer, to > >>>>> this disscussion. > >>>>> > >>>>> [ ]'s > >>>>> Michel Machado > >>>>> > >>>>> On 10/13/20 9:53 AM, Kevin Traynor wrote: &g

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-14 Thread Medvedkin, Vladimir
https://github.com/AltraMayor/gatekeeper/blob/master/gt/lua_lpm.c#L235-L248 On 09/10/2020 07:54, Ruifeng Wang wrote: -Original Message- From: Kevin Traynor Sent: Wednesday, September 30, 2020 4:46 PM To: Ruifeng Wang ; Medvedkin, Vladimir ; Bruce Richardson Cc: dev@dpdk.org; Honnap

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-13 Thread Michel Machado
mber 30, 2020 4:46 PM To: Ruifeng Wang ; Medvedkin, Vladimir ; Bruce Richardson Cc: dev@dpdk.org; Honnappa Nagarahalli ; nd Subject: Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data On 16/09/2020 04:17, Ruifeng Wang wrote: -Original Message- From: Medvedkin, Vladimir Sent: Wednesday

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-13 Thread Michel Machado
lpm.c#L235-L248 On 09/10/2020 07:54, Ruifeng Wang wrote: -Original Message- From: Kevin Traynor Sent: Wednesday, September 30, 2020 4:46 PM To: Ruifeng Wang ; Medvedkin, Vladimir ; Bruce Richardson Cc: dev@dpdk.org; Honnappa Nagarahalli ; nd Subject: Re: [dpdk-dev] [PATCH 2/2] lpm: hid

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-13 Thread Michel Machado
ct: Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data On 16/09/2020 04:17, Ruifeng Wang wrote: -Original Message- From: Medvedkin, Vladimir Sent: Wednesday, September 16, 2020 12:28 AM To: Bruce Richardson ; Ruifeng Wang Cc: dev@dpdk.org; Honnappa Nagarahalli ; nd Subject: Re: [PATC

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-13 Thread Medvedkin, Vladimir
tember 30, 2020 4:46 PM To: Ruifeng Wang ; Medvedkin, Vladimir ; Bruce Richardson Cc: dev@dpdk.org; Honnappa Nagarahalli ; nd Subject: Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data On 16/09/2020 04:17, Ruifeng Wang wrote: -Original Message- From: Medvedkin, Vladimir Sent: Wednes

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-13 Thread Medvedkin, Vladimir
Traynor Sent: Wednesday, September 30, 2020 4:46 PM To: Ruifeng Wang ; Medvedkin, Vladimir ; Bruce Richardson Cc: dev@dpdk.org; Honnappa Nagarahalli ; nd Subject: Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data On 16/09/2020 04:17, Ruifeng Wang wrote: -Original Message- From: Medvedkin,

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-13 Thread Kevin Traynor
wrote: > >> -Original Message- >> From: Kevin Traynor >> Sent: Wednesday, September 30, 2020 4:46 PM >> To: Ruifeng Wang ; Medvedkin, Vladimir >> ; Bruce Richardson >> >> Cc: dev@dpdk.org; Honnappa Nagarahalli >> ; nd >> Subject: Re: [dpdk-dev]

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-10-08 Thread Ruifeng Wang
> -Original Message- > From: Kevin Traynor > Sent: Wednesday, September 30, 2020 4:46 PM > To: Ruifeng Wang ; Medvedkin, Vladimir > ; Bruce Richardson > > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; nd > Subject: Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-09-30 Thread Kevin Traynor
On 16/09/2020 04:17, Ruifeng Wang wrote: > >> -Original Message- >> From: Medvedkin, Vladimir >> Sent: Wednesday, September 16, 2020 12:28 AM >> To: Bruce Richardson ; Ruifeng Wang >> >> Cc: dev@dpdk.org; Honnappa Nagarahalli >> ; nd >> Subject: Re: [PATCH 2/2] lpm: hide internal data >

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-09-15 Thread Ruifeng Wang
> -Original Message- > From: Medvedkin, Vladimir > Sent: Wednesday, September 16, 2020 12:28 AM > To: Bruce Richardson ; Ruifeng Wang > > Cc: dev@dpdk.org; Honnappa Nagarahalli > ; nd > Subject: Re: [PATCH 2/2] lpm: hide internal data > > Hi Ruifeng, > > On 15/09/2020 17:02, Bruce Ric

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-09-15 Thread Medvedkin, Vladimir
Hi Ruifeng, On 15/09/2020 17:02, Bruce Richardson wrote: On Mon, Sep 07, 2020 at 04:15:17PM +0800, Ruifeng Wang wrote: Fields except tbl24 and tbl8 in rte_lpm structure have no need to be exposed to the user. Hide the unneeded exposure of structure fields for better ABI maintainability. Sugges

Re: [dpdk-dev] [PATCH 2/2] lpm: hide internal data

2020-09-15 Thread Bruce Richardson
On Mon, Sep 07, 2020 at 04:15:17PM +0800, Ruifeng Wang wrote: > Fields except tbl24 and tbl8 in rte_lpm structure have no > need to be exposed to the user. > Hide the unneeded exposure of structure fields for better > ABI maintainability. > > Suggested-by: David Marchand > Signed-off-by: Ruifeng